Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified render options to add cookies #3701

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lvindotexe
Copy link

cookies that were set with the Astro.cookie.set() method were not passed on to the CloudflareResult. and some cookies were also duplicated before they were converted into specific AWS Responses

Copy link

changeset-bot bot commented Mar 10, 2024

⚠️ No Changeset found

Latest commit: 14253eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jayair
Copy link
Contributor

jayair commented Mar 12, 2024

@bayssmekanique does this make sense to you? Or is this more for Frank to look at?

@bayssmekanique
Copy link
Contributor

@lvindotexe, could you provide some context to the original issue this PR addresses. I see the code and I think it's harmless enough, but I'm not sure I understand the original issue. Is it possible to get a reproduction step or example of some sort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants