Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Await All Functions Builds During file.change event #3679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdalton713
Copy link

This fixes lambda functions updates when 1 file change effects multiple lambdas. More details here: https://discord.com/channels/983865673656705025/1207750476213256222

Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: 0f52c0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jayair
Copy link
Contributor

jayair commented Feb 20, 2024

Taking a look

Logger.debug("Rebuilt function", functionID);
}
} catch {}
console.log("Rebuilt function", functionID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this log be in here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ya'lls master branch has it too - I've personally found it super helpful lately since I noticed my functions haven't been rebuilding consistently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants