[future/auth] use query params on success too #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bringing back this behavior from v2.24.22 https://github.com/sst/sst/blob/766436883ee7b7b23637cf9d3effd08a07b861fe/packages/sst/src/node/future/auth/handler.ts#L300 so `state` query param is also copied from query params on success step too.
|
benjamine
changed the title
|
Taking a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bringing back this behavior from v2.24.22
sst/packages/sst/src/node/future/auth/handler.ts
Line 300 in 7664368
statequery param is also copied from query params on success step too.the regression observed is that
?state=is empty when doing the final redirect after success (at least tested with google adapter) asstatearrives as a query param to the auth handler.link to discord with more details: https://discord.com/channels/983865673656705025/1082462837710012508/1203065839591489566