Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SsrSite/NextjsSite]: Add cdk server configuration to ImageOptimizationFunction in SsrSite base construct #3612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jplwood
Copy link
Contributor

@jplwood jplwood commented Jan 8, 2024

enhancement (?)

See #3607, this provides a fix for that issue in the NextjsSite construct where VPC configuration is only applied to the origins of type: 'function' (see this and this), but not the image optimization function (see this and this).

All constructs inheriting from the SsrSite construct will inherit this change. Hoping for confirmation from a reviewer that this is desirable.

Copy link

changeset-bot bot commented Jan 8, 2024

⚠️ No Changeset found

Latest commit: 36cac17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jplwood jplwood changed the title Add cdk server configuration to ImageOptimizationFunction in SsrSite base construct [SsrSite/NextjsSite]: Add cdk server configuration to ImageOptimizationFunction in SsrSite base construct Jan 8, 2024
@jayair
Copy link
Contributor

jayair commented Jan 9, 2024

Ah cool. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants