fix child processes becoming zombies in dev #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw-in
added a commit
to qw-in/ion
that referenced
this pull request
May 8, 2024
qw-in
added a commit
to qw-in/ion
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #317
TL;DR I was using volta, which spawns node in a child process & it wasn't getting cleaned up.
This pr attempts to address that by always cleaning up the process & all sub-processes. To do so I lifted some code from go-cmd.
I didn't try very hard on the naming/factoring - happy to change it to whatever y'all prefer
Not sure if it could be used in more places too - noticed something similar in client already:
ion/pkg/server/client.go
Line 41 in 11e5f33