fix(aws/https-redirect) default viewer certificate TLS to version 1.2 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethcarlton
changed the title
|
After looking into this further, the ssl protocol errors I'm seeing may be caused by the strictness of TLS 1.2 (2021) - I am only seeing the issue on certain public networks (like coffee shops). Still looking into it to determine what the root cause is. Modifying the minimum protocol for the redirect may not actually be the best approach. If it's only redirecting maybe it is better to optimize for compatibility? Or maybe use the oldest version of TLS 1.2 (2018) |
|
Yeah I think compatibility makes the most sense here. |
|
Agreed. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the TLS version to 1.2 (recommended) for the https redirect distribution. This matches the default for the base cdn distribution as well.
Previously was falling back to TLS 1.0 as the default