New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabling lambda url cors error #229

Open

qw-in wants to merge 1 commit into sst:dev from qw-in:aws-function-url-disable-cors

Contributor

qw-in commented Apr 12, 2024 •

edited

Previously, disabling url.cors after it had been enabled would have no effect or throw an error, this attempts to fix that.

Reproduce:

First deploy

new sst.aws.Function("Cors", {
  handler: "cors.handler",
  url: {
    cors: true,
  },
});

sst deploy
sst refresh # potentially unneeded

Second deploy

new sst.aws.Function("Cors", {
  handler: "cors.handler",
  url: {
    cors: false,
  },
});

sst deploy
×  Failed
   Cors sst:aws:Function → Cors aws:lambda:FunctionUrl
   updating urn:pulumi:...::sst:aws:Function$aws:lambda/functionUrl:FunctionUrl::Cors: 1 error occurred:
   
   InvalidParameterValueException: You can't leave AllowOrigins as empty when Cors is enabled.

After this change, cors should be disabled successfully


          disable lambda url cors when false

f0ce43b

jayair requested a review from fwang

April 12, 2024 23:04

qw-in changed the title ~~Fix disablling lambda url cors error~~ Fix disabling lambda url cors error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment