Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow falsy secret values #220

Merged
merged 2 commits into from May 18, 2024
Merged

Conversation

carloitaben
Copy link
Contributor

I'm setting some secrets in my project and I need some placeholder values to be falsy values. For example, when using a db file with SQLite for local development with Drizzle and Turso I want to set the secrets this way:

new sst.Secret("TursoDatabaseUrl", "file:local.db")
new sst.Secret("TursoDatabaseAuthToken", "")

In order to do this

import { Resource } from "sst"
import type { Config } from "drizzle-kit"

export default {
  // ...
  dbCredentials: {
    url: Resource.TursoDatabaseUrl,
    authToken: Resource.TursoDatabaseAuthToken,
  },
} satisfies Config

I'm sure there's a safer way to do this, just trying to kick off the discussion with this PR 馃檪

@jayair jayair requested a review from thdxr April 12, 2024 23:07
@jayair
Copy link
Contributor

jayair commented Apr 12, 2024

@thdxr take a look?

qw-in pushed a commit to qw-in/ion that referenced this pull request May 8, 2024
qw-in pushed a commit to qw-in/ion that referenced this pull request May 9, 2024
Co-authored-by: Quinn Blenkinsop <quinn@blenkinsop.net>
@thdxr thdxr merged commit 5dd59b0 into sst:dev May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants