Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netconf framing protocol #946

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

schaveyt
Copy link

@schaveyt schaveyt commented Apr 3, 2022

Problem

The implementation was not compliant to the RFC6242. Although the client does NOT support the framing protocol, if the server reported that is did, the client would still try to using the framing protocol. The result is that client and server are unable to communicate at the RPC XML layer and the session times out.

Solution

The solution is to simply never used framing protocol regardless of whether the server does or not.

Additional Minor Changes

  1. Address null pointer exception when the netconf_session is disposing.
  2. Add an example of the RPC XML to use when transmitting calls.

Experimental Release for .NET Standard 2.1

https://github.com/schaveyt/SSH.NET/releases/tag/2021.04.02

…ing_protocol

Adding co-author credit from sshnet#639:

Co-authored-by: Jason Larke <jason.larke@curtin.edu.au>
@Rob-Hague
Copy link
Collaborator

I think we should take this one on good faith. I have no knowledge of netconf and we have no testing but it seems reasonable to me, and with #639 and #1197 there are at least 3 people for whom it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants