Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: alert on admitted parents only #492

Closed
wants to merge 9 commits into from

Conversation

annekebr
Copy link
Collaborator

@annekebr annekebr commented Jan 21, 2022

Fixes #379

Description

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

@annekebr annekebr force-pushed the refactor/adjust-alerting-frequency branch from c88d7db to a850dc3 Compare February 11, 2022 22:03
@codecov-commenter
Copy link

Codecov Report

Merging #492 (7aac0f2) into develop (29803af) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #492      +/-   ##
===========================================
+ Coverage    94.40%   94.59%   +0.19%     
===========================================
  Files           22       22              
  Lines         1125     1129       +4     
===========================================
+ Hits          1062     1068       +6     
+ Misses          63       61       -2     
Impacted Files Coverage Δ
connaisseur/alert.py 98.03% <100.00%> (+0.05%) ⬆️
connaisseur/flask_application.py 94.79% <100.00%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29803af...7aac0f2. Read the comment docs.

@xopham xopham linked an issue Mar 4, 2022 that may be closed by this pull request
@phbelitz
Copy link
Member

no longer applicable with golang switch

@phbelitz phbelitz closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerting: slack integration sends too many posts
4 participants