Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: native helm support #430

Closed
wants to merge 3 commits into from
Closed

feat: native helm support #430

wants to merge 3 commits into from

Conversation

xopham
Copy link
Collaborator

@xopham xopham commented Nov 26, 2021

Fixes no issue

Description

  • helm values, Chart, and templates are refactored/improved to provide more native helm support and improve usability
  • helm and app versioning are properly seperated

⚠️ WIP NOTES:

  • Discuss using appVersion as v2.2.0 instead of 2.20
  • Consider further version definitions e.g. k8s
  • ADR 8 on Helm versioning
  • docs
    • new quick start
    • new getting started
    • add versioning notes on start page
  • cleanup helm/values.yaml (adjust defaults, take out examples)
  • add improvements by @annekebr

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

Starkteetje and others added 2 commits November 26, 2021 15:34
This commit refactors the import order (PEP-8), some comments, many docstrings (PEP-257), a regex and some types where there were inconsistencies present
helm values, Chart, and templates are refactored/improved to provide more native helm support and improve usability
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #430 (2eba1d4) into develop (bf4de6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #430   +/-   ##
========================================
  Coverage    94.47%   94.47%           
========================================
  Files           22       22           
  Lines         1105     1105           
========================================
  Hits          1044     1044           
  Misses          61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4de6f...2eba1d4. Read the comment docs.

@phbelitz
Copy link
Member

no longer applicable with golang switch

@phbelitz phbelitz closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants