Test/integration/rework #1607
Test/integration/rework #1607
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1607 +/- ##
===========================================
- Coverage 88.08% 87.87% -0.22%
===========================================
Files 36 35 -1
Lines 2509 2465 -44
===========================================
- Hits 2210 2166 -44
Misses 255 255
Partials 44 44 ☔ View full report in Codecov by Sentry. |
phbelitz
force-pushed
the
test/integration/rework
branch
from
7534717
to
7362cef
Compare
phbelitz
force-pushed
the
test/integration/rework
branch
from
536ccf6
to
a72c827
Compare
| @@ -40,3 +40,9 @@ kind-dev: | |||
|
|
|||
| lint: | |||
| golangci-lint run --skip-dirs="test" | |||
|
|
|||
| integration: | |||
There was a problem hiding this comment.
I guess this should replace kind-int-test above?
| @@ -40,3 +40,9 @@ kind-dev: | |||
|
|
|||
| lint: | |||
| golangci-lint run --skip-dirs="test" | |||
|
|
|||
There was a problem hiding this comment.
Not only your changes, but I guess PHONY needs an update
| @@ -7,7 +7,7 @@ kubernetes: | |||
| # Connaisseur application version depends on the layout of the Helm deployment | |||
| # Thus, if unset, we default to the appVersion of the Chart.yaml | |||
| # tag: v1.2.3 | |||
| pullPolicy: Always | |||
| pullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
Not that I'm against this change per se, but that doesn't fit here
| - `cert`: Test a custom TLS certificate for Connaisseur. | ||
| - `redis-cert`: Test a custom TLS certificate for Redis. |
There was a problem hiding this comment.
These are not just custom certs, but also update process for these, right?
| - `redis-cert`: Test a custom TLS certificate for Redis. | ||
| - `upgrade`: Test upgradability of Connaisseur. | ||
| - `alerting`: Test alerting mechanisms. | ||
| - `other-ns`: Test whether Connaisseur works in other namespaces. |
There was a problem hiding this comment.
This is not really clear to me
| - id: pre-05 | ||
| txt: Testing non official docker image and non sse testimage... | ||
| ref: non-official/non-sse:test | ||
| expected_msg: static deny |
| expected_msg: error during cosign validation | ||
| - id: r-06 | ||
| txt: Testing signed cosign image... | ||
| ref: securesystemsengineering/testimage:co-signed |
| echo -e ${SUCCESS} | ||
| fi | ||
| fi | ||
| } |
|
|
||
| ghcr_case() { | ||
| if [[ -n "${IMAGE+x}" && -n "${IMAGEPULLSECRET+x}" && "${GITHUB_WORKFLOW}" != "release" ]]; then | ||
| return 0 |
There was a problem hiding this comment.
I think this is somewhat counter-intuitive with exit codes being the exact opposite of this, but maybe that's just me
| @@ -0,0 +1,141 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Why did you replace run_integration_tests with this? The previous utility did more. For example, I could locally run all integration tests with a single, easy command and go get a drink. With this it would be a lot harden
Rework of integration tests
Checklist
developChart.yaml(if necessary)