Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux VM kind #1976

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Linux VM kind #1976

wants to merge 3 commits into from

Conversation

jmussmann
Copy link

This PR add support for a vrnlab linux VM kind.

The corresponding PR in the vrnetlab repository is "Add Ubuntu Support #183" for ubuntu.

The code would also support other linux distribution. This is why the kind is called vr_linux and not vr_ubuntu.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 53.46%. Comparing base (cf84f5f) to head (6fcac59).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   53.64%   53.46%   -0.18%     
==========================================
  Files         160      161       +1     
  Lines       11538    11570      +32     
==========================================
- Hits         6189     6186       -3     
- Misses       4485     4518      +33     
- Partials      864      866       +2     
Files Coverage Δ
clab/register.go 100.00% <100.00%> (ø)
nodes/vr_linux/vr-linux.go 3.22% <3.22%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant