added reboot instruction #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
srevinsaju
reviewed
Oct 6, 2022
install.sh
Outdated
| @@ -177,3 +177,4 @@ fi | |||
| # Installation Complete | |||
| echo | |||
| echo [~] Installation Complete.... | |||
| echo [~] Reboot the terminal to affect changes. | |||
There was a problem hiding this comment.
Probably you should use "restart" the terminal.
There was a problem hiding this comment.
Alternatively, why don't you integrate this answer into the shell script: https://unix.stackexchange.com/questions/217905/restart-bash-from-terminal-without-restarting-the-terminal-application-mac
The exec bash command has been added as per suggestion. Albeit after further re-attempts, I have found out it happens to work even without retarting the terminal. Have added the command anyways just in case,
srevinsaju
reviewed
Oct 23, 2022
| @@ -177,3 +177,5 @@ fi | |||
| # Installation Complete | |||
| echo | |||
| echo [~] Installation Complete.... | |||
| echo [~] Restart the terminal to affect changes. | |||
There was a problem hiding this comment.
I think Restart the terminal for the changes to take effect. seems more correct. What do you think?
srevinsaju
reviewed
Oct 23, 2022
| @@ -177,3 +177,5 @@ fi | |||
| # Installation Complete | |||
| echo | |||
| echo [~] Installation Complete.... | |||
| echo [~] Restart the terminal to affect changes. | |||
| exec bash | |||
There was a problem hiding this comment.
Should probably be $SHELL here 🤔
srevinsaju
force-pushed
the
main
branch
2 times, most recently
from
38c27b8
to
d13a35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.