Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Fix date reading #1291

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix date reading #1291

wants to merge 2 commits into from

Conversation

zeripath
Copy link

In the British TZ the following time:

1579639200 +0100

will be erroneously parsed as being with the GMT TZ.
This leads to multiple errors with GPG validation.

This PR fixes this by using the provided TZ information to
create a FixedZone and sets that as the TZ

@lafriks
Copy link

lafriks commented Feb 22, 2020

Tests need to be fixed

@zeripath
Copy link
Author

Sigh. Let me just drop the name.

plumbing/object/object.go Outdated Show resolved Hide resolved
plumbing/object/object.go Outdated Show resolved Hide resolved
In the British TZ the following time:

```
1579639200 +0100
```

will be erroneously parsed as being with the GMT TZ.
This leads to multiple errors with GPG validation.

This PR fixes this by using the provided TZ information to
create a FixedZone and sets that as the TZ

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Author

zeripath commented Feb 23, 2020

CI has been placated

Signed-off-by: Andrew Thornton <art27@cantab.net>
@mcuadros
Copy link
Contributor

Merged at go-git/go-git#2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants