Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Add global and system config support #1243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

djgilcrease
Copy link

Loads the config the same way git does, System, then Global, then Local so overrides are maintained properly.

Closes #760

@djgilcrease djgilcrease changed the title Add global and system support Add global and system config support Nov 15, 2019
Closes src-d#760

Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com>
Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com>
@cap10morgan
Copy link

Thanks for submitting this PR, @djgilcrease. I would love to have this functionality for a project I'm working on using go-git. It seems that they've moved all development to this repo: https://github.com/go-git/go-git. Can you resubmit this PR over there?

@cap10morgan
Copy link

Ran into an issue with this, which I may try to fix and submit an updated PR to the new go-git/go-git repo. Namely, when you load up your config with this code and then later run a SetConfig, it copies your merged system, global, local config into your local .git/config file. That's probably not what we want for general behavior there.

@djgilcrease
Copy link
Author

sounds good to me, I am on vacation for the next few weeks so will not be able to do anything with it for a long while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .gitconfig support
2 participants