Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect workflow parent name used in Workflow Core documentation #1266

Merged

Conversation

sssurvey
Copy link
Contributor

Within the Workflow Core -> Composing Workflows documentation, a minor error can be noticed in the last paragraph. It appears that an incorrect class name has been used to refer to the parent workflow, which is contrary to the documentation context and understanding. Based on my understanding, the parent workflow should be correctly identified as EmailBrowserWorkflow, rather than EmailInboxWorkflow.

The paragraph I am referring to is:

Whenever such a Workflow Action cascade fires, the root Workflow is asked for a new Rendering. Just as before, EmailInboxWorkflow delegates to its two children for their Renderings, this time providing the new value of selection as the updated Props for MessageWorkflow.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@rjrjr rjrjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

And please stay tuned -- planning a significant update to the tutorials in a few weeks.

@sssurvey
Copy link
Contributor Author

No problem, 👀 out for the update!

@rjrjr rjrjr merged commit 0665c75 into square:main Jun 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants