Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WeakHashMap enhancement and expand #2632

Merged
merged 4 commits into from Mar 26, 2024
Merged

WeakHashMap enhancement and expand #2632

merged 4 commits into from Mar 26, 2024

Commits on Feb 18, 2024

  1. WeakHashMap enhancement and expand

    @EpicDima
    EpicDima committed Feb 18, 2024
    Copy the full SHA
    963d25a View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Enforce non nullable (it's always a ref)

    @pyricau
    pyricau committed Mar 26, 2024
    Copy the full SHA
    35e2c35 View commit details
    Browse the repository at this point in the history

  2. Remove sequence since we only ever return the value, instead of key +… 

    … value in the map case
    @pyricau
    pyricau committed Mar 26, 2024
    Copy the full SHA
    b3ef2cb View commit details
    Browse the repository at this point in the history

  3. Fix WeakHashMap tests 

    - Change tests to leverage a retained key rather than a weakly reachable one, which created flakiness and wasn't testing the intended behavior (a cleared weak key sees the entry added to the reference queue but we don't want to find objects there anyway)
- Removed tests that didn't seem ended (we're mostly interested in the expander case, and I didn't get what the singleton case is supposed to be about)
    @pyricau
    pyricau committed Mar 26, 2024
    Copy the full SHA
    de1ece1 View commit details
    Browse the repository at this point in the history