Use checkTarget on modifiers #961

GlassBricks · 2020-08-02T17:35:00Z

This probably needs proofreading.

Other comments:

Parameters can have some modifiers that properties can (that they otherwise shouldn't); this is to keep consistent behavior when parameters are turned into primary constructor properties.
- A test case was found that doesn't produce compiling code (final does not apply to non-property parameter). This is fixed in a separate commit.
In/Out (type variable) modifiers already have their own check.
The Reified KModifier isn't used at all. See add doc about reified keyword #939

This does not cover all combinations of modifiers. In/Out modifiers have their own target check. Some property modifiers are applied to parameters because they can be used as constructor properties (?)

Kotlin parameters are always final, and cannot have a `final` modifier. Final is still allowed on parameters because they can be used as constructor properties.

JakeWharton · 2020-08-03T17:47:22Z

kotlinpoet/src/main/java/com/squareup/kotlinpoet/TypeAliasSpec.kt

@@ -124,11 +124,7 @@ public class TypeAliasSpec private constructor(
        addAnnotation(annotation.asClassName())

    public fun build(): TypeAliasSpec {
-      for (it in modifiers) {
-        require(it in ALLOWABLE_MODIFIERS) {


This variable now unused?

Benjamin Ye added 2 commits August 2, 2020 10:15

Add modifier target checking

4a25a3a

This does not cover all combinations of modifiers. In/Out modifiers have their own target check. Some property modifiers are applied to parameters because they can be used as constructor properties (?)

Fix test that does not compile (using final parameters)

2f86b55

Kotlin parameters are always final, and cannot have a `final` modifier. Final is still allowed on parameters because they can be used as constructor properties.

JakeWharton approved these changes Aug 3, 2020

View reviewed changes

Egorand changed the base branch from master to main July 5, 2023 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use checkTarget on modifiers #961

Use checkTarget on modifiers #961

GlassBricks commented Aug 2, 2020

JakeWharton Aug 3, 2020

Use checkTarget on modifiers #961

Are you sure you want to change the base?

Use checkTarget on modifiers #961

Conversation

GlassBricks commented Aug 2, 2020

JakeWharton Aug 3, 2020

Choose a reason for hiding this comment