feat: Add flag to print sha256 fingerprint. #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sha-256 fingerprint of the raw cert is the most definitive way to differentiate unique certs.
|
|
jordyn
approved these changes
Aug 15, 2023
mbyczkowski
reviewed
Aug 15, 2023
| @@ -25,6 +26,7 @@ var ( | |||
| dumpPem = dump.Flag("pem", "Write output as PEM blocks instead of human-readable format.").Short('m').Bool() | |||
| dumpJSON = dump.Flag("json", "Write output as machine-readable JSON format.").Short('j').Bool() | |||
| dumpFirst = dump.Flag("first", "Only display the first certificate. This flag can be paired with --json or --pem.").Short('l').Bool() | |||
| dumpSha256 = dump.Flag("sha256", "Write sha256sum of cert to output, not compatible --pem or --json.").Short('s').Bool() | |||
There was a problem hiding this comment.
Any reason this fingerprint couldn't also be added in JSON output?
And I wonder if we could name that something like --show-fingerprint (not sure what a good one letter flag to give it then, though) and just default to sha-256 for now? If we ever wanted to provide other hashing means we could turn the flag into an option with an argument.
There was a problem hiding this comment.
It definitely could be added, but look later how if *dumpJson {} is implemented. I'd have to rework the JSON printing and didn't think it was worth it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sha-256 fingerprint of the raw cert is the most definitive way to differentiate unique certs.