Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request dep #1183

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Remove request dep #1183

merged 3 commits into from
Mar 18, 2023

Conversation

rickbergfalk
Copy link
Collaborator

Removes request dependency from server/package.json. It was used for an unused Apache Drill method, so it should be safe to remove.

request as a package is deprecated.

1 other use of request exists in server codebase via the clickhouse client. This also needs to be dealt with to address https://github.com/sqlpad/sqlpad/security/dependabot/55

@rickbergfalk rickbergfalk merged commit 46a84e1 into master Mar 18, 2023
@rickbergfalk rickbergfalk deleted the remove-request-dep branch March 18, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant