Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite3 column table alias #3

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

d3x0r
Copy link

@d3x0r d3x0r commented Mar 11, 2021

d3x0r added 8 commits January 12, 2021 09:23
…_ENABLE_COLUMN_METADATA, sqlite3_column_table_alias returns the alias specified in the query.
…ed; Add sqlite3_column_table_alias returns the alias of the table the column belongs to, which was specified in the prepared statement.
@d3x0r d3x0r marked this pull request as ready for review March 11, 2021 05:34
@justinclift
Copy link

justinclift commented Mar 11, 2021

Not super sure, but this probably won't get merged from here.

Saying that because this is just a mirror of the actual repo, and the SQLite Bug report page says to report bugs via their public forum.

That being said, SQLite is Open Source, not Open Contribution, so the SQLite authors would need to re-implement any changes. 🤷

@d3x0r
Copy link
Author

d3x0r commented Nov 16, 2021

The first message associated with the PR was a Sqlite Forum link.... so that was already done.
That's interesting about 'open source, but not open contribution' how about 'open fix your non-functionality' ?
I'm going to keep quietly keeping this in sync... (although I might have to close this specific PR - it seems to represent changes that https://github.com/d3x0r/sqlite/tree/sqlite3_column_table_alias doesn't actually have against master. ) same branch; I started to open a new PR, but realized this one should just update...
This gives a way to get a standard diff which could be used with patch ....

@justinclift
Copy link

As a thought, is this something that you could turn into a SQLite extension instead?

That way, it could be directly hosted in one of the SQLite extension repositories (there seem to be a few now), and people would probably find it easier. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants