Fix some bugs in Doris implementation #853

codenohup · 2023-07-09T04:13:47Z

Hi all.
Thanks to Sqlancer, I found a lot of logic bugs in Doris, some of them have been fixed by the Doris community.
Now I found some unexpected bugs in the implementation of dors, see below:

CAST(0.19511769711971283 AS NULL) , cast a value or column to null
CREATE TABLE t0(c0 DATETIME NOT NULL DEFAULT NULL), assign the default value NULL to the non-nullable columns in the CREATE TABLE statement
When testing oracle, UNION ALL should be used instead of UNION in some cases
SELECT t0.c0 FROM t1, t0 GROUP BY t1.c0, select fields not in group by

This PR tries to fix them.

Thanks for your review and thanks again for the Sqlancer tool!

codenohup · 2023-07-09T04:15:47Z

To avoid misunderstanding, the original implementation of Doris (#758) is done by me, this is another Github account of mine.

mrigger

Thanks a lot for keeping working on the Doris implementation! It would be great to fix the CI tests as well. Could you please look into this if you have time?

mrigger · 2023-07-10T07:55:01Z

src/sqlancer/doris/DorisSchema.java

            DorisDataType type = DorisDataType.getRandomWithoutNull();
+            if (globalState != null) {


Is there any valid case where globalState can be null? If not, you can do a check at the beginning of the method and throw an IllegalArgumentException if it is.

There shouldn't be null here, I've removed it

mrigger · 2023-07-10T07:57:34Z

src/sqlancer/doris/DorisSchema.java

+                    || type == DorisDataType.DATETIME && globalState.getDbmsSpecificOptions().testDateTimeConstants
+                    || type == DorisDataType.VARCHAR && globalState.getDbmsSpecificOptions().testStringConstants
+                    ) {
+                        typeIsQualified = true;


I don't understand what we are checking here. Is it for primitive types?

For example, the user does not want to test the datetime type, so the datetime type should not be generated from the CREATE table. I have corrected the writing style here.

I think it would be better to select from a list of possible options, and throw an exception if no type can be selected. See

sqlancer/src/sqlancer/duckdb/gen/DuckDBExpressionGenerator.java

Line 53 in e3fbde0

List<Expression> possibleOptions = new ArrayList<>(Arrays.asList(Expression.values()));

for this pattern.

src/sqlancer/doris/oracle/tlp/DorisQueryPartitioningAggregateTester.java

codenohup · 2023-07-10T13:51:10Z

Thanks a lot for keeping working on the Doris implementation! It would be great to fix the CI tests as well. Could you please look into this if you have time?

Sorry, I don't have enough hardware environment to test this CI. I'll try to find someone in the Doris community to do this.

codenohup · 2023-07-10T14:47:09Z

Thanks a lot for keeping working on the Doris implementation! It would be great to fix the CI tests as well. Could you please look into this if you have time?

I have correct the code, can you help me to review again? Thanks.

mrigger · 2023-07-10T21:06:51Z

Thanks a lot for keeping working on the Doris implementation! It would be great to fix the CI tests as well. Could you please look into this if you have time?

Sorry, I don't have enough hardware environment to test this CI. I'll try to find someone in the Doris community to do this.

I think you could just do this by creating a PR and seeing if the CI passes with your changes? This would work best after merging this PR, since the CI tests are not automatically executed for new contributors.

mrigger · 2023-07-15T17:44:42Z

src/sqlancer/doris/DorisSchema.java

-                dt = Randomly.fromOptions(values());
-            } while (dt == DorisDataType.NULL);
-            return dt;
+        public static DorisDataType getRandomWithoutNull(DorisOptions options) {


I'd actually suggest including all types by default, and removing them when an option is specified. With the current version, if someone adds a new type, they need to debug why it is not generated.

I'd suggest that we merge the PR after fixing this, so the CI tests run automatically, making it easier to fix them.

I'd suggest that we merge the PR after fixing this, so the CI tests run automatically, making it easier to fix them.

Yes, I'm working on fixing CI. But I'm only free on weekends, so it might be a bit slow.

I'd actually suggest including all types by default, and removing them when an option is specified. With the current version, if someone adds a new type, they need to debug why it is not generated.

I think this can be divided into two functions, one is to generate all basic types without parameters, and the other is to generate legal types based on options.

hello-stephen · 2023-07-17T07:11:17Z

I tried this PR and found that no.4 issue(select fields not in group by) still exists，
for example, SELECT t1.c1, t0.c0, t1.c0 FROM t1, t0 GROUP BY t1.c1, t1.c0; , SELECT t0.c1, t1.c0 FROM t0, t1 GROUP BY t0.c1, t0.c0;

maybe it needs to have a look again.

Signed-off-by: codenohup <huangxu.walker@gmail.com>

codenohup · 2023-07-22T07:41:15Z

I tried this PR and found that no.4 issue(select fields not in group by) still exists， for example, SELECT t1.c1, t0.c0, t1.c0 FROM t1, t0 GROUP BY t1.c1, t1.c0; , SELECT t0.c1, t1.c0 FROM t0, t1 GROUP BY t0.c1, t0.c0;

maybe it needs to have a look again.

Hey, I updated it again, you can try again to see if it works.

mrigger

LGTM, thanks!

mrigger · 2023-07-23T15:21:09Z

Can you please fix the redundant important? The CI tests are currently failing because of that.

hello-stephen · 2023-07-28T07:31:43Z

I tried this PR and found that no.4 issue(select fields not in group by) still exists， for example, SELECT t1.c1, t0.c0, t1.c0 FROM t1, t0 GROUP BY t1.c1, t1.c0; , SELECT t0.c1, t1.c0 FROM t0, t1 GROUP BY t0.c1, t0.c0;
maybe it needs to have a look again.

Hey, I updated it again, you can try again to see if it works.

SELECT SUM('-1680854620') FROM t0; SELECT SUM(CAST('' AS DATETIME) ) FROM t0;
will meet Unexpected exception: sum requires a numeric or boolean parameter: sum('-1680854620')
doris does not support this now, could you please modify it?

--java.lang.AssertionError: SELECT DISTINCT * FROM (SELECT DISTINCT t0.c1, t1.c0 FROM t1, t0 WHERE NULL UNION ALL SELECT DISTINCT t0.c1, t1.c0 FROM t1, t0 WHERE (NOT NULL) UNION ALL SELECT DISTINCT t0.c1, t1.c0 FROM t1, t0 WHERE ((NULL) IS NULL)) tmpTable;
-- at sqlancer.common.query.SQLQueryAdapter.checkException(SQLQueryAdapter.java:111)
-- at sqlancer.common.query.SQLQueryAdapter.executeAndGet(SQLQueryAdapter.java:141)
-- at sqlancer.ComparatorHelper.getResultSetFirstColumnAsString(ComparatorHelper.java:55)
-- at sqlancer.doris.oracle.tlp.DorisQueryPartitioningDistinctTester.check(DorisQueryPartitioningDistinctTester.java:40)
-- at sqlancer.common.oracle.CompositeTestOracle.check(CompositeTestOracle.java:22)
-- at sqlancer.ProviderAdapter.generateAndTestDatabase(ProviderAdapter.java:61)
-- at sqlancer.Main$DBMSExecutor.run(Main.java:388)
-- at sqlancer.Main$2.run(Main.java:583)
-- at sqlancer.Main$2.runThread(Main.java:565)
-- at sqlancer.Main$2.run(Main.java:556)
-- at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
-- at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
-- at java.base/java.lang.Thread.run(Thread.java:829)
--Caused by: java.sql.SQLException: errCode = 2, detailMessage = Unexpected exception: argument 1 requires boolean type, however 'NULL' is of null type
-- at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
-- at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
-- at com.mysql.cj.jdbc.StatementImpl.executeQuery(StatementImpl.java:1200)
-- at sqlancer.common.query.SQLQueryAdapter.executeAndGet(SQLQueryAdapter.java:131)
-- ... 11 more
---- Time: 2023/07/28 09:42:28
-- Database: database14
-- Database version: 5.7.99
-- seed value: 1690508512305
DROP DATABASE IF EXISTS database14;
CREATE DATABASE database14;
USE database14;
CREATE TABLE t0(c0 DATEV2, c1 CHAR(89) DEFAULT '/e]3') DISTRIBUTED BY HASH (c0) BUCKETS 11 PROPERTIES ("replication_num" = "1");
CREATE TABLE t1(c0 BOOLEAN DEFAULT false) AGGREGATE KEY(c0) DISTRIBUTED BY HASH (c0) PROPERTIES ("replication_num" = "1");
CREATE TABLE t1(c0 INT DEFAULT -525669762) DISTRIBUTED BY HASH (c0) BUCKETS 18 PROPERTIES ("replication_num" = "1");
CREATE TABLE t1(c0 VARCHAR(89) DEFAULT '-525669762') DISTRIBUTED BY HASH (c0) BUCKETS 4 PROPERTIES ("replication_num" = "1");
INSERT INTO t0 (c1, c0) VALUES ('uFAU58', DATE '1971-01-11');
INSERT INTO t1 (c0) VALUES ('&E!f');
INSERT INTO t1 (c0) VALUES ('iH');
INSERT INTO t1 (c0) VALUES (DEFAULT);
INSERT INTO t0 (c0) VALUES (DATE '1970-10-24'), (DATE '1970-03-15');
INSERT INTO t0 (c0) VALUES (DATE '1970-05-05');
INSERT INTO t1 (c0) VALUES ('DMO'), ('');
INSERT INTO t0 (c1) VALUES ('');
INSERT INTO t1 (c0) VALUES ('5hc{}-');
INSERT INTO t1 (c0) VALUES ('a>0');
INSERT INTO t0 (c0) VALUES (DATE '1970-04-27');
INSERT INTO t0 (c0, c1) VALUES (DATE '1970-07-23', '');
INSERT INTO t1 (c0) VALUES ('0.72896520762826'), ('ꡒwroZ');
INSERT INTO t0 (c1) VALUES ('');
INSERT INTO t1 (c0) VALUES (DEFAULT), (DEFAULT);
INSERT INTO t1 (c0) VALUES ('qSfD%~');
INSERT INTO t0 (c1, c0) VALUES ('P,', DATE '1970-11-29');
INSERT INTO t1 (c0) VALUES ('-1888442286'), ('g');
INSERT INTO t0 (c0) VALUES (DATE '1970-04-12');
INSERT INTO t1 (c0) VALUES (DEFAULT);
INSERT INTO t1 (c0) VALUES ('倮M'), (DEFAULT);

here, meet error Unexpected exception: argument 1 requires boolean type, however 'NULL' is of null type
but when I try to run the SQL manually, it just works, but I don't know why

hello-stephen · 2023-08-11T11:44:46Z

one more,
I found this log generate by sqlancer,

--java.lang.AssertionError: SELECT SUM(count) FROM (SELECT CAST(CAST('p^M|-Ft2O' AS BOOLEAN)  IS NOT NULL AND CAST('p^M|-Ft2O' AS BOOLEAN)  AS INT) as count FROM  t0 RIGHT  OUTER JOIN t1 ON (((NOT ((-548572585)<<(1443052302))))and(((NULL) IS NOT NULL)))) as res;
--  at sqlancer.common.query.SQLQueryAdapter.checkException(SQLQueryAdapter.java:111)
--  at sqlancer.common.query.SQLQueryAdapter.executeAndGet(SQLQueryAdapter.java:141)
--  at sqlancer.common.query.Query.executeAndGetLogged(Query.java:51)
--  at sqlancer.doris.oracle.DorisNoRECOracle.getUnoptimizedQueryCount(DorisNoRECOracle.java:89)
--  at sqlancer.doris.oracle.DorisNoRECOracle.check(DorisNoRECOracle.java:61)
--  at sqlancer.common.oracle.CompositeTestOracle.check(CompositeTestOracle.java:22)
--  at sqlancer.ProviderAdapter.generateAndTestDatabase(ProviderAdapter.java:61)
--  at sqlancer.Main$DBMSExecutor.run(Main.java:388)
--  at sqlancer.Main$2.run(Main.java:583)
--  at sqlancer.Main$2.runThread(Main.java:565)
--  at sqlancer.Main$2.run(Main.java:556)
--  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
--  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
--  at java.base/java.lang.Thread.run(Thread.java:829)
--Caused by: java.sql.SQLException: ArrayIndexOutOfBoundsException, msg: 2
--  at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
--  at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
--  at com.mysql.cj.jdbc.StatementImpl.executeQuery(StatementImpl.java:1200)
--  at sqlancer.common.query.SQLQueryAdapter.executeAndGet(SQLQueryAdapter.java:131)
--  ... 12 more
---- Time: 2023/08/11 15:18:37
-- Database: database39
-- Database version: 5.7.99
-- seed value: 1691738082566
DROP DATABASE IF EXISTS database39;
CREATE DATABASE database39;
USE database39;
CREATE TABLE t0(c0 CHAR(190) DEFAULT 'W6뻛뻛UpD', c1 VARCHAR(190) DEFAULT 'W6뻛뻛UpD') DISTRIBUTED BY HASH (c0, c1) PROPERTIES ("replication_num" = "1");
CREATE TABLE t1(c0 VARCHAR(190) DEFAULT '') DISTRIBUTED BY HASH (c0) BUCKETS 15 PROPERTIES ("replication_num" = "1");
INSERT INTO t1 (c0) VALUES ('-781402405');
INSERT INTO t1 (c0) VALUES ('0.9339626230427275'), ('굕+78P>q'), ('-781402405');
INSERT INTO t0 (c1) VALUES ('-781402405');
INSERT INTO t0 (c1) VALUES ('-296506027'), (DEFAULT), ('');
INSERT INTO t1 (c0) VALUES ('F]H');
INSERT INTO t1 (c0) VALUES ('+_z ');
INSERT INTO t0 (c1, c0) VALUES ('AqYv\'_', 'W6뻛뻛UpD');
INSERT INTO t1 (c0) VALUES ('-781402405');
INSERT INTO t0 (c1) VALUES ('g');
INSERT INTO t0 (c1) VALUES ('镃쿥');
INSERT INTO t0 (c0, c1) VALUES ('', '-1e500'), ('', '');
INSERT INTO t1 (c0) VALUES (DEFAULT);
INSERT INTO t0 (c1, c0) VALUES ('H7\\z', 'E*EOsWy6镃');
INSERT INTO t0 (c1) VALUES ('mnE1Nr굕\n ');
INSERT INTO t1 (c0) VALUES ('Gk');

by when try to reproduce，I got this

mysql> SELECT SUM(count) FROM (SELECT CAST(CAST('p^M|-Ft2O' AS BOOLEAN)  IS NOT NULL AND CAST('p^M|-Ft2O' AS BOOLEAN)  AS INT) as count FROM  t0 RIGHT  OUTER JOIN t1 ON (((NOT ((-548572585)<<(1443052302))))and(((NULL) IS NOT NULL)))) as res;
ERROR 1105 (HY000): errCode = 2, detailMessage = Syntax error in line 1:
...1 ON (((NOT ((-548572585)<<(1443052302))))and(((NULL) ...
                             ^
Encountered: <
Expected: IDENTIFIER

Doris seems do not support operator << , why sqlancer can run?

mrigger reviewed Jul 10, 2023

View reviewed changes

codenohup force-pushed the main branch 2 times, most recently from cc3d0f0 to 6a9e723 Compare July 10, 2023 14:22

mrigger reviewed Jul 15, 2023

View reviewed changes

codenohup added 4 commits July 22, 2023 15:32

Fix some bugs in Doris implementation

d1d653b

Signed-off-by: codenohup <huangxu.walker@gmail.com>

Fix some bugs in Doris implementation

86ea121

Signed-off-by: codenohup <huangxu.walker@gmail.com>

add more debug info in doris CI

e2eb366

fix select list not in group by columns

a603fb1

Signed-off-by: codenohup <huangxu.walker@gmail.com>

codenohup force-pushed the main branch from 9728a6b to a603fb1 Compare July 22, 2023 07:32

mrigger approved these changes Jul 23, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some bugs in Doris implementation #853

Fix some bugs in Doris implementation #853

codenohup commented Jul 9, 2023

codenohup commented Jul 9, 2023

mrigger left a comment

mrigger Jul 10, 2023

codenohup Jul 10, 2023

mrigger Jul 10, 2023

codenohup Jul 10, 2023

mrigger Jul 10, 2023

codenohup commented Jul 10, 2023

codenohup commented Jul 10, 2023

mrigger commented Jul 10, 2023

mrigger Jul 15, 2023

mrigger Jul 15, 2023

codenohup Jul 22, 2023

codenohup Jul 22, 2023

hello-stephen commented Jul 17, 2023

codenohup commented Jul 22, 2023

mrigger left a comment

mrigger commented Jul 23, 2023

hello-stephen commented Jul 28, 2023

hello-stephen commented Aug 11, 2023

		DorisDataType type = DorisDataType.getRandomWithoutNull();
		if (globalState != null) {

Fix some bugs in Doris implementation #853

Are you sure you want to change the base?

Fix some bugs in Doris implementation #853

Conversation

codenohup commented Jul 9, 2023

codenohup commented Jul 9, 2023

mrigger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenohup commented Jul 10, 2023

codenohup commented Jul 10, 2023

mrigger commented Jul 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hello-stephen commented Jul 17, 2023

codenohup commented Jul 22, 2023

mrigger left a comment

Choose a reason for hiding this comment

mrigger commented Jul 23, 2023

hello-stephen commented Jul 28, 2023

hello-stephen commented Aug 11, 2023