Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with betterWhiteSpace #2

Merged
merged 1 commit into from May 25, 2017
Merged

Merge with betterWhiteSpace #2

merged 1 commit into from May 25, 2017

Conversation

chmln
Copy link
Contributor

@chmln chmln commented May 24, 2017

As discussed in #1
馃帀

@spywhere
Copy link
Owner

I'll take a look tonight and will merged upon reviewed.

@spywhere spywhere merged commit 1673741 into spywhere:master May 25, 2017
@spywhere
Copy link
Owner

The extension has been published (v0.3.0). I also improve your decoration setup to make the continuous line of tab indicator and size consistency.

screen shot 2560-05-25 at 10 28 07

@chmln
Copy link
Contributor Author

chmln commented May 28, 2017

Awesome!

But..the whole reason I made my separate extension was to get rid of the hideous tab indicator, which is still the default in whiteviz.

I think its best not to have it configurable and make the best choice for the user, providing em-dash tabs out-of-the-box. There should be better defaults and less options to choose from, since most users won't be customizing them.

Also, the tab character has to be determined dynamically based on user's tabSize editor option, since you need a different char for two-width and four-width tabs.

@spywhere
Copy link
Owner

The reasons why I want the extension to be customizable is because of it is not just whitespace visualization (upon selection) that I want this extension to cover, but many issues (such as microsoft/vscode#2085 or microsoft/vscode#2878) can also be covered. With this, they can make the best out of one extension instead of choosing multiple variations just to suit them.

Yes, most user might not customizing it, but provide it as a customizable option help power users to specifically choose which feature they want to enabled.

And since some users might not from a modern text editor, set the default options to something else that seems not align with the editor's look and feel, it would give the editor a bit strange to those users, as you state that most users would not customizing them.

For tabSize, although Unicode provided those tab variations as you are currently using, the actual size when using it in the editor is different, so that is why I use the full-width em-dash instead. Though you could said that setting it to some specific font would give the same effect, however, not every machine have the same font set and not to mention if the users change their editor's font.

Hopefully you would understand the points behind the decision I am making here.

Anyway, thanks for the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants