Add blog post for conda-based installers #214
Conversation
CAM-Gerlach
force-pushed
the
cbi-blog
branch
from
8190918
to
ca0ad93
Compare
There was a problem hiding this comment.
Per our discussion, I went ahead and made commits to add you as an author and resolve a couple other technical issues, fix the line breaks, and downscale and optimize the images. This makes them display at a much more appropriate and non-pixelated size (as they appear upscaled from their originals, perhaps due to hiDPI), and reduces their file size by between 4x and 10x, for relatively minimal visible quality loss.
Additionally, I made non-trivial comments on the text as suggestions, which as always you can apply by going to Files -> Add to batch [for each] -> Commit.
Thanks!
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
@CAM-Gerlach, all your suggestions looked good to me; thank you for reviewing! |
|
Thanks @mrclary ! Looks pretty good to me now, but for some reason the checks didn't fire as they should have—I'll close and re-open to see if that will proc them, and assuming everything's good I'll ping @ccordoba12 for a final review. Thanks! |
There was a problem hiding this comment.
Everything now LGTM from me; thanks @mrclary ! I'll leave this to @ccordoba12 to give this a final review.
Thanks for responses, @ccordoba12. I think they were very helpful. I had just a few counter-suggestions; when we reach consensus, I'll commit all suggestions together. |
There was a problem hiding this comment.
My further recommended revisions, where applicable, of @ccordoba12 's suggested changes.
EDIT: Note that @mrclary 's comments didn't show up for me when I was reviewing (since I started the review last night and only finished now), so I'm going back and addressing them.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
|
@ccordoba12 and @CAM-Gerlach, seems like we have converged. Thanks for your feedback. Whoever merges this, remember to update the |
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
There was a problem hiding this comment.
Thanks for your patience @mrclary. This is finally going in!
ccordoba12
changed the title
No description provided.