Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve UX of the Plots plugin #22029

Merged
merged 12 commits into from
May 15, 2024

Commits on May 11, 2024

  1. Plots: Change auto_fit_plotting option to False

    - That makes the zoom in/out buttons be enabled by default, which is a
    much better usability experience than having them disabled.
    - Adjust the plot scale factor according to the scaling of fitted image,
    so that zoom in/out works as expected.
    - Fix test_zoom_figure_viewer, which checked that functionality.
    ccordoba12 committed May 11, 2024
    Configuration menu
    Copy the full SHA
    7b2d7d9 View commit details
    Browse the repository at this point in the history
  2. Plots: Use a vertical layout in ThumbnailScrollBar

    That simplifies the layout of that widget and it'll also allow us to
    change the order of thumbnails in it with drag and drop.
    ccordoba12 committed May 11, 2024
    Configuration menu
    Copy the full SHA
    87a1014 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c0823a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    97f70d5 View commit details
    Browse the repository at this point in the history
  5. Plots: Improve organization of buttons in its main toolbar

    Also, increase default width of thumbnail bar to go with this change.
    ccordoba12 committed May 11, 2024
    Configuration menu
    Copy the full SHA
    654fc61 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    1c4af7d View commit details
    Browse the repository at this point in the history
  2. Plots: Provide a better UX for the auto-fit plots action

    - Move it to the plugin toolbar and check it by default after every new
    plot is generated so the plot always fit in the pane.
    - Unchecking the action makes the plot to zoom in at its full size.
    - Clicking the zoom in/out buttons unchecks the action, which means the
    plot doesn't fit into the pane anymore.
    - Save the auto-fit state in the current thumbnail. This will be useful
    to restore the zoom level of each plot when loaded.
    - Remove the auto_fit_plotting option because it's no longer needed.
    ccordoba12 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    05ff6a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c3e7e54 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7777e45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a95c07 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Plots: Add shortcut for the auto-fit action

    - Also, change shortcuts for save/close all plots to avoid issues in
    Eastern European languages.
    - Add clarifying comment the usage of timers to set the scrollbar values
    after a figure is loaded.
    ccordoba12 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0f68022 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    d351599 View commit details
    Browse the repository at this point in the history