Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fixes to improve compatibility with PySide2 #22024

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

rear1019
Copy link
Contributor

Description of Changes

This PR fixes multiple context menu actions when using PySide2. Note: This PR is for 5.x branch, however, is also applicable to master. Please let me know if I should create a PR for master as well.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

rear1019

See commit “pyside: Fix preferences modified by checkboxes” for details.
@ccordoba12
Copy link
Member

This PR fixes multiple context menu actions when using PySide2.

Thanks!

Note: This PR is for 5.x branch, however, is also applicable to master. Please let me know if I should create a PR for master as well.

Don't worry, we merge PRs against 5.x to master too. So, there's no need of an extra PR.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @rear1019!

@ccordoba12 ccordoba12 merged commit c3e512e into spyder-ide:5.x Apr 26, 2024
23 checks passed
ccordoba12 added a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants