Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use notarytool instead of altool (Installers) #21953

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Apr 1, 2024

Copied notarize.sh from master branch, but retaining DMG variable.

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Just used the version of notarize.sh from master.
altool was deprecated last year, but I anticipated that we would not be developing on 5.x for this long, so I did not update to notarytool. The notarizing on master has always used notarytool.

Issue(s) Resolved

Fixes #21951

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Copied notarize.sh from master branch, but retaining DMG variable.
@mrclary mrclary self-assigned this Apr 1, 2024
@dalthviz dalthviz added this to the v5.5.4 milestone Apr 2, 2024
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary ! From my understanding things look good here 👍, but just in case, is there anything else pending to do before merging this?

@mrclary
Copy link
Contributor Author

mrclary commented Apr 2, 2024

It should be good to go. Thanks @dalthviz .

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 changed the title PR: Use notarytool instead of altool PR: Use notarytool instead of altool (Installers) Apr 2, 2024
@ccordoba12 ccordoba12 merged commit af31793 into spyder-ide:5.x Apr 2, 2024
3 checks passed
ccordoba12 added a commit that referenced this pull request Apr 2, 2024
@mrclary mrclary deleted the issue-21951 branch April 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants