PR: Bump pylint to >=3.1,4 and python-lsp-server to >=1.11.0,<1.12.0
#21942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumped pylsp because of python-lsp/python-lsp-server#543 |
bnavigator
changed the title
ccordoba12
changed the title
ccordoba12
previously approved these changes
Mar 29, 2024
There was a problem hiding this comment.
@bnavigator, besides addressing my comment below, you also need to sync our subrepo for python-lsp-server (i.e. a copy we have of that project here).
For that, please follow these instructions, specifically this command:
git subrepo pull external-deps/python-lsp-server -r https://github.com/python-lsp/python-lsp-server.git -b develop -u -f
|
Hello @bnavigator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-03-29 20:40:35 UTC |
…rver.git --branch=develop --update --force external-deps/python-lsp-server subrepo: subdir: "external-deps/python-lsp-server" merged: "4c0e99b41" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "4c0e99b41" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
Closed
ccordoba12
changed the title
>=3.1,4 and python-lsp-server to >=1.11
ccordoba12
changed the title
>=3.1,4 and python-lsp-server to >=1.11>=3.1,4 and python-lsp-server to >=1.11.0,<1.12.0
ccordoba12
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
Looks good to me now, thanks @bnavigator!
Note: The failure in our tests was fixed in PR #21939.
ccordoba12
added a commit
that referenced
this pull request
Mar 30, 2024
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Apr 2, 2024
https://build.opensuse.org/request/show/1163542 by user bnavigator + anag+factory - Update to 5.5.3 * Fix critical error when starting IPython console kernels on macOS and Linux in conda environments. - Release 5.5.2 * Activate environment for consoles that run in the same environment as Spyder. * Fix IPython kernel hangs when using a different graphic backend than Inline. * Fix check for updates mechanism when running Spyder from a conda installation. - Add spyder-pr21939-qtawesome1.3.patch gh#spyder-ide/spyder#21939 but also allow 1.2 - Add spyder-pr21942-pylint3.1.patch gh#spyder-ide/spyder#21942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Bump Pylint and python-lsp-server to the new versions
Issue(s) Resolved
Fixes #21936
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: bnavigator