PR: Fix class/function selector for split editors (Editor) #20961
Conversation
dalthviz
changed the title
|
Hi @ccordoba12, sorry for the slow response. Unfortunately, I haven’t been able to work on Spyder over the last few weeks. I will try to update this PR the next few days.
I managed to come up with a fix if I remember correctly. I will try to make a (draft) PR the next few days. |
rear1019
force-pushed
the
fix_classfuncdropdown
branch
from
f9fdb63
to
44be806
Compare
|
@ccordoba12 I have added the suggested changes. Concerning broken indention guides and code folding in cloned editors, see #21033. |
There was a problem hiding this comment.
One last minor comment for you @rear1019, the rest looks good to me.
Great! Thanks for addressing that problem too. |
rear1019
force-pushed
the
fix_classfuncdropdown
branch
from
44be806
to
2009c49
Compare
The test fails as of this commit due to a bug which is fixed in the next commit
Split editors are “clones” of the “main editor”. Handling of some LSP
related events (e.g. folding and symbols) is performed by the main
editor only (see e.g. CodeEditor.start_completion_services() and
EditorStack.create_new_editor()).
Add missing update of the class and function selector [1] for split
editors.
(Also see PR [2] which fixed a related issue in the Outline plugin.)
[1] See menu entry “Source → Show selection for classes and function”;
the selector is shown at the top of the editor’s viewport, just
below the tabbar.
[2] spyder-ide#20221
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
rear1019
force-pushed
the
fix_classfuncdropdown
branch
from
2009c49
to
b4eb8fb
Compare
Description of Changes
This PR fixes missing updates of the class and function selector of vertically/horizontally split (cloned) editors. See commit message for details.
Note: Update of indent guides and code folding in cloned editors is broken as well (similar root cause). I have looked into fixing that as well, however, have not succeeded so far.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
rear1019