Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remember undocked state of plugins when closed and allow to close Outline when the Editor is maximized or in an Editor window #19784

Merged
merged 30 commits into from
May 25, 2024

Commits on Dec 23, 2023

  1. Configuration menu
    Copy the full SHA
    ab6b051 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. API: Add the possibility to close undocked windows

    - This allows users to show plugins directly undocked, i.e. without
    making them first visible but docked on the main window to then undock
    them.
    - Also, improve typing a bit.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    bc4b011 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f643ff View commit details
    Browse the repository at this point in the history
  3. Outline: Allow to close it when shown next to the maximized editor

    - To close it the user can click the Close action in its Options menu or
    go to the Panes menu.
    - Hide the Outline's Undock and Lock/unlock actions when shown in the
    maximized editor because it doesn't make sense to show them in that
    case.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    dd13a51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48172dd View commit details
    Browse the repository at this point in the history
  5. API: Save if plugin window was undocked before hiding it in our confi…

    …g system
    
    That allows to make persistent that state across Spyder sessions.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    e5256be View commit details
    Browse the repository at this point in the history
  6. Testing: Move function to get a random dockable plugin out of a test

    That will allow us to use it in other tests.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    77b394c View commit details
    Browse the repository at this point in the history
  7. Testing: Check the new close plugins when undocked functionality

    - Also, check the visibility of the Outline when shown with the
    maximized editor.
    - Fix test_no_update_outline because it was failing.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    2f455ac View commit details
    Browse the repository at this point in the history
  8. Stylesheet: Improve style of QSplitter handlers

    - Reduce their size to make them a bit smaller than the QMainWindow
    separators. That will help users to navigate our UI more easily.
    - Also, remove images of QMainWindow separators because they are not
    visible.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    f745ffb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c52dc88 View commit details
    Browse the repository at this point in the history
  10. Editor: Allow to close Outline in EditorWidget from its Options menu

    This will present to users the same UI as the one shown when the editor
    is maximized.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    5d3baeb View commit details
    Browse the repository at this point in the history
  11. Main menu: Use SpyderMenuMixin API to create the app menus

    This will allow us to reuse those menus in other places they are needed.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1d81836 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    577c4f4 View commit details
    Browse the repository at this point in the history
  13. Toolbar: Register toolbar toogle view actions in ACTION_REGISTRY

    - This will allow us to easily access them in other places.
    - Also, fix typing and improve code style in its container.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    6227e08 View commit details
    Browse the repository at this point in the history
  14. API: Add toolbar_id to the constructor of ApplicationToolbar

    That way it'll be easier to create those kind of toolbars in other
    widgets.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    ddac76a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3fd86b1 View commit details
    Browse the repository at this point in the history
  16. Editor: Add action to EditorMainWindow View menu to show/hide Outline

    This provides a very similar UX to the one users see when maximizing the
    editor in the main window.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    3410fea View commit details
    Browse the repository at this point in the history
  17. Editor: Hide splitter handle in EditorMainWindow when collpasing Outline

    - This preserves the checked state of new Outline action shown in the
    View menu.
    - It also removes the handle which looks like an extra and odd border in
    the window.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    080ad88 View commit details
    Browse the repository at this point in the history
  18. Main menu: Add singleton with the menubar stylesheet to its API

    - That way it can be used by other plugins or widgets.
    - Use it to set the menubar stylesheet of EditorMainWindow.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    61f5fe2 View commit details
    Browse the repository at this point in the history
  19. Testing: Check the behavior of Outline and toolbars in editor windows

    - Also, fix failing tests for the Working directory.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    fe613bc View commit details
    Browse the repository at this point in the history
  20. Editor: Catch KeyError when getting toolbars/menus in EditorMainWindow

    Also, check for the presence of splitter handler because it can't be
    available during tests.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    80ced8c View commit details
    Browse the repository at this point in the history
  21. Layout: Fix error when plugins required for tabification are unavailable

    This was causing a crash at startup in some cases.
    ccordoba12 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    73e1022 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    f9de0fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da5976d View commit details
    Browse the repository at this point in the history
  3. Testing: Fix test_editor_window_outline_and_toolbars

    - Also, remove unnecessary condition in test_undock_plugin_and_close and
    style from the app stylesheet.
    ccordoba12 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    695c4c3 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from code review

    Co-authored-by: Jitse Niesen <jitseniesen@yahoo.com>
    ccordoba12 and jitseniesen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    11f671a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f7653c8 View commit details
    Browse the repository at this point in the history
  6. API: Simplify text of lock_unlock_action

    This helps to have a more straightforward UI because "Move" means
    basically "Move to another position". And "Lock" means "Lock position".
    ccordoba12 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c36103a View commit details
    Browse the repository at this point in the history
  7. Outline Explorer: Hide unnecessary actions when the plugin is undocked

    Also, remove a couple of unneeded imports.
    ccordoba12 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    369544d View commit details
    Browse the repository at this point in the history
  8. Layout: Fix visual glitches when switching layouts

    - We were not unmaximizing a possibly maximized plugin before the
    switch, which left the window in an inconsistent state.
    - We also need to reapply the dock tabbar style after the switch so the
    window looks as expected.
    ccordoba12 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1149dcf View commit details
    Browse the repository at this point in the history