PR: Use '!' for Pdb commands and add other options to control the debugger (IPython console) #12134

impact27 · 2020-04-04T06:21:49Z

Description of Changes

Wrote at least one-line docstrings (for any new functions)
Added unit test(s) covering the changes (if testable)

Included a screenshot or animation (if affecting the UI, see Licecap)

Use '!' before Pdb commands and nothing before python code, as is the case in IPython

Issue(s) Resolved

Depends on spyder-ide/spyder-kernels#214

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

impact27 · 2020-06-24T08:30:27Z

I switched commands and text because I am tired to have a variable named step that I can't use while debugging

so:

ipdb> step = 10

ipdb> step
10

ipdb> !step
> /usr/local/Cellar/python/3...

impact27 · 2020-10-12T13:48:39Z

I removed the explore mode and replaced by spyder-ide/spyder-kernels@82617ad

This means typing "u" in the terminal will go up unless u is defined. So the code takes precedence on the commands rather than the other way around. This way pdb can be used in essentially the current way, but the conflicts resolve in favor of the code rather than the commands, which is more intuitive.

…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "82617ad15" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "separate_cmd_input" commit: "82617ad15" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"

ccordoba12 · 2020-10-23T01:20:49Z

This means typing "u" in the terminal will go up unless u is defined. So the code takes precedence on the commands rather than the other way around. This way pdb can be used in essentially the current way, but the conflicts resolve in favor of the code rather than the commands, which is more intuitive.

Great! That's a very nice and intuitive solution solution!

Thanks @impact27 for implementing it.

ccordoba12

Apart from the minor comment I left and fixing the merge conflict with our subrepo, I think this one is ready.

spyder/config/main.py

…/github.com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "97909c82f" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "separate_cmd_input" commit: "97909c82f" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"

impact27 · 2020-10-23T06:17:32Z

Should this behaviour be the default? I think it makes sense as new users will be less surprised but could be a bit surprising for users that are used to pdb.

ccordoba12 · 2020-10-23T15:27:19Z

/show binder

github-actions · 2020-10-23T15:27:35Z

👈 Launch a Binder instance on this branch

ccordoba12 · 2020-10-23T22:59:29Z

Should this behaviour be the default?

Yes, I totally agree.

I think it makes sense as new users will be less surprised but could be a bit surprising for users that are used to pdb.

Agreed too.

And what do you think if we give seasoned Pdb users a hint about what's happening, by showing a message like this?

…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "427046552" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "separate_cmd_input" commit: "427046552" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"

ccordoba12 · 2020-10-24T13:10:57Z

@impact27, I think this is good to go now. Please resync our subrepo because I just merged PR spyder-ide/spyder-kernels#214.

…der-ide/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "5e430c34b" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "1.x" commit: "5e430c34b" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"

ccordoba12 · 2020-10-24T14:41:36Z

Please merge with 4.x to fix the merge conflict.

ccordoba12 · 2020-10-24T15:45:11Z

I did it myself because I need it to base another PR on top of this one. Sorry for the hassle.

ccordoba12

Thanks a lot @impact27 for this! Terrific addition!

This comment has been minimized.

Sign in to view

impact27 changed the title ~~Separate cmd input~~ Separate pdb input Apr 4, 2020

impact27 changed the title ~~Separate pdb input~~ Separate pdb input from general IO Apr 4, 2020

impact27 closed this Apr 4, 2020

impact27 reopened this Apr 4, 2020

impact27 closed this Apr 5, 2020

impact27 reopened this Apr 5, 2020

impact27 changed the title ~~Separate pdb input from general IO~~ Separate pdb input from general IO and cleanup debugging.py Apr 5, 2020

impact27 force-pushed the separate_cmd_input branch from e655890 to 6dafbdb Compare April 6, 2020 18:04

impact27 mentioned this pull request Apr 15, 2020

test_mainwindow.py opens too many file descriptors and sockets #12328

Closed

impact27 force-pushed the separate_cmd_input branch from 26b8329 to 238eaff Compare April 19, 2020 14:04

impact27 force-pushed the separate_cmd_input branch 3 times, most recently from 046437b to df406e9 Compare May 22, 2020 08:00

impact27 changed the title ~~Separate pdb input from general IO and cleanup debugging.py~~ Separate pdb input from general IO May 25, 2020

impact27 force-pushed the separate_cmd_input branch 2 times, most recently from 74ddde9 to 7bc6561 Compare June 30, 2020 18:25

impact27 changed the title ~~Separate pdb input from general IO~~ PR: Enhance PdB by using '!' for commands and showing matplotlib figures while debugging Jul 1, 2020

impact27 force-pushed the separate_cmd_input branch 3 times, most recently from 47a6e56 to 21c44e4 Compare July 2, 2020 12:31

impact27 closed this Jul 2, 2020

impact27 reopened this Jul 2, 2020

impact27 mentioned this pull request Jul 2, 2020

Kernel fails to send config sometimes #13164

Closed

10 tasks

impact27 force-pushed the separate_cmd_input branch from a1d4834 to b2c395f Compare July 4, 2020 14:33

impact27 force-pushed the separate_cmd_input branch from 98ca6da to d11c97f Compare July 18, 2020 07:37

impact27 changed the title ~~PR: Enhance PdB by using '!' for commands and showing matplotlib figures while debugging~~ PR: Use '!' for Pdb commands [Depends on #13327] Jul 18, 2020

impact27 force-pushed the separate_cmd_input branch 2 times, most recently from 0bd7791 to 3698b89 Compare July 24, 2020 06:49

Quentin Peter and others added 7 commits October 13, 2020 08:02

remove explore mode test

324ca89

check falls back on pdb commands

6ad8dd4

remove unused shortcut

8910d71

Fix history filtering

ba0bed2

Fix silent_execute

4e2db17

pep8: Limit line length

2411082

ccordoba12 reviewed Oct 23, 2020

View reviewed changes

spyder/config/main.py Outdated Show resolved Hide resolved

Quentin Peter added 3 commits October 23, 2020 08:14

Merge remote-tracking branch 'upstream/4.x' into separate_cmd_input

aa73a47

bump CONF_VERSION

c165780

Quentin Peter added 2 commits October 24, 2020 08:08

change default value for pdb_use_exclamation_mark

3abf6c6

Merge branch '4.x' into separate_cmd_input

f3bc395

ccordoba12 approved these changes Oct 24, 2020

View reviewed changes

ccordoba12 changed the title ~~PR: Use '!' for Pdb commands~~ PR: Use '!' for Pdb commands and add other options to control the deby (IPython console) Oct 24, 2020

ccordoba12 changed the title ~~PR: Use '!' for Pdb commands and add other options to control the deby (IPython console)~~ PR: Use '!' for Pdb commands and add other options to control the debugger (IPython console) Oct 24, 2020

ccordoba12 merged commit 6554746 into spyder-ide:4.x Oct 24, 2020

ccordoba12 added a commit that referenced this pull request Oct 24, 2020

Merge from 4.x: PR #12134

c15d347

impact27 mentioned this pull request Mar 30, 2021

The current file cannot be closed because it is in debug mode. #13189

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Use '!' for Pdb commands and add other options to control the debugger (IPython console) #12134

PR: Use '!' for Pdb commands and add other options to control the debugger (IPython console) #12134

impact27 commented Apr 4, 2020 •

edited by ccordoba12

This comment has been minimized.

impact27 commented Jun 24, 2020

impact27 commented Oct 12, 2020

ccordoba12 commented Oct 23, 2020

ccordoba12 left a comment

impact27 commented Oct 23, 2020

ccordoba12 commented Oct 23, 2020

github-actions bot commented Oct 23, 2020

ccordoba12 commented Oct 23, 2020 •

edited

ccordoba12 commented Oct 24, 2020

ccordoba12 commented Oct 24, 2020

ccordoba12 commented Oct 24, 2020 •

edited

ccordoba12 left a comment

PR: Use '!' for Pdb commands and add other options to control the debugger (IPython console) #12134

PR: Use '!' for Pdb commands and add other options to control the debugger (IPython console) #12134

Conversation

impact27 commented Apr 4, 2020 • edited by ccordoba12

Description of Changes

Issue(s) Resolved

Affirmation

This comment has been minimized.

impact27 commented Jun 24, 2020

impact27 commented Oct 12, 2020

ccordoba12 commented Oct 23, 2020

ccordoba12 left a comment

Choose a reason for hiding this comment

impact27 commented Oct 23, 2020

ccordoba12 commented Oct 23, 2020

github-actions bot commented Oct 23, 2020

ccordoba12 commented Oct 23, 2020 • edited

ccordoba12 commented Oct 24, 2020

ccordoba12 commented Oct 24, 2020

ccordoba12 commented Oct 24, 2020 • edited

ccordoba12 left a comment

Choose a reason for hiding this comment

impact27 commented Apr 4, 2020 •

edited by ccordoba12

ccordoba12 commented Oct 23, 2020 •

edited

ccordoba12 commented Oct 24, 2020 •

edited