Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make compatible with Spyder 6 #447

Closed
wants to merge 1 commit into from

Conversation

mrclary
Copy link

@mrclary mrclary commented Nov 4, 2023

@jitseniesen, I don't know what the release strategy is for spyder-notebook.
I believe this will be a breaking change, so this will only be compatible with certain Spyder versions. Let me know what you'd like to do.

@jitseniesen
Copy link
Member

Spyder-notebook 0.5.x is compatible with Spyder 5.x only. The master branch will become spyder-notebook 0.6.0 and be compatible with 6.x only. I am not sure this is the best approach, but it is what I eventually settled on for all the plugins that I maintain.

If I remember correctly, your first commit (updating the import of shorten_paths) is already in the master branch but the second one is not - but I did not check. Feel free to let me take care of it; alternatively, target the master branch with this PR.

@mrclary
Copy link
Author

mrclary commented Nov 6, 2023

Spyder-notebook 0.5.x is compatible with Spyder 5.x only. The master branch will become spyder-notebook 0.6.0 and be compatible with 6.x only. I am not sure this is the best approach, but it is what I eventually settled on for all the plugins that I maintain.

If I remember correctly, your first commit (updating the import of shorten_paths) is already in the master branch but the second one is not - but I did not check. Feel free to let me take care of it; alternatively, target the master branch with this PR.

Thanks for clarifying. I'll fix it them to be on the correct branch. I'm not challenging your approach, I just want to understand that we can know how best to move forward.

@mrclary mrclary changed the base branch from 0.5.x to master January 25, 2024 15:41
@mrclary mrclary changed the base branch from master to 0.5.x January 25, 2024 15:41
@mrclary mrclary changed the base branch from 0.5.x to master January 25, 2024 15:50
@jitseniesen
Copy link
Member

Closing because this PR is subsumed by PR #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants