add accumulators #300
Open
add accumulators #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. It's failing due to an openssl dependency fail. Could use some help with how to fix your test environment on this. |
clehner
reviewed
Sep 21, 2021
|
After making the change in #300 (comment), build completes, but some tests fail: 4 failing testsThis is with running I skipped tests that were taking > 60 seconds, for practical reasons: patch to ignore slow testsdiff --git a/accumulator-ecc/src/accumulator.rs b/accumulator-ecc/src/accumulator.rs
index cf2c7c7..09d04f1 100644
--- a/accumulator-ecc/src/accumulator.rs
+++ b/accumulator-ecc/src/accumulator.rs
@@ -237,2 +237,3 @@ mod tests {
#[test]
+ #[ignore]
fn one_year_updates() {
diff --git a/pairings/src/bls12_381/ec/g1.rs b/pairings/src/bls12_381/ec/g1.rs
index f0ccece..9c7d161 100644
--- a/pairings/src/bls12_381/ec/g1.rs
+++ b/pairings/src/bls12_381/ec/g1.rs
@@ -698,2 +698,3 @@ fn test_g1_same_y() {
#[test]
+#[ignore]
fn g1_curve_tests() {
diff --git a/pairings/src/bls12_381/ec/g2.rs b/pairings/src/bls12_381/ec/g2.rs
index f6719f2..d2e04b7 100644
--- a/pairings/src/bls12_381/ec/g2.rs
+++ b/pairings/src/bls12_381/ec/g2.rs
@@ -828,2 +828,3 @@ use rand_core::SeedableRng;
#[test]
+#[ignore]
fn g2_add_test() {
diff --git a/pairings/src/bls12_381/fq12.rs b/pairings/src/bls12_381/fq12.rs
index 2534d20..6ebb900 100644
--- a/pairings/src/bls12_381/fq12.rs
+++ b/pairings/src/bls12_381/fq12.rs
@@ -183,2 +183,3 @@ fn test_fq12_mul_by_014() {
#[test]
+#[ignore]
fn fq12_field_tests() {
diff --git a/pairings/src/bls12_381/fq2.rs b/pairings/src/bls12_381/fq2.rs
index b0774aa..b56a511 100644
--- a/pairings/src/bls12_381/fq2.rs
+++ b/pairings/src/bls12_381/fq2.rs
@@ -982,2 +982,3 @@ fn test_fq2_mul_nonresidue() {
#[test]
+#[ignore]
fn fq2_field_tests() {
diff --git a/pairings/src/bls12_381/fq6.rs b/pairings/src/bls12_381/fq6.rs
index c21b9f9..5c3cde9 100644
--- a/pairings/src/bls12_381/fq6.rs
+++ b/pairings/src/bls12_381/fq6.rs
@@ -372,2 +372,3 @@ fn test_fq6_mul_by_01() {
#[test]
+#[ignore]
fn fq6_field_tests() {
diff --git a/pairings/src/bls12_381/mod.rs b/pairings/src/bls12_381/mod.rs
index da008cd..1da309c 100644
--- a/pairings/src/bls12_381/mod.rs
+++ b/pairings/src/bls12_381/mod.rs
@@ -379,2 +379,3 @@ impl G2Prepared {
#[test]
+#[ignore]
fn bls12_engine_tests() {
diff --git a/pairings/src/bn256/ec/g1.rs b/pairings/src/bn256/ec/g1.rs
index a3e8f57..21a150f 100644
--- a/pairings/src/bn256/ec/g1.rs
+++ b/pairings/src/bn256/ec/g1.rs
@@ -386,2 +386,3 @@ fn test_base_point_addition_and_doubling() {
#[test]
+#[ignore]
fn g1_curve_tests() {
diff --git a/pairings/src/bn256/ec/g2.rs b/pairings/src/bn256/ec/g2.rs
index ba05bb2..d03ce57 100644
--- a/pairings/src/bn256/ec/g2.rs
+++ b/pairings/src/bn256/ec/g2.rs
@@ -599,2 +599,3 @@ fn test_addition_and_doubling() {
#[test]
+#[ignore]
fn random_negation_tests() {
@@ -634,2 +635,3 @@ fn random_negation_tests() {
#[test]
+#[ignore]
fn mul_by_order_tests() {
diff --git a/pairings/src/bn256/fq12.rs b/pairings/src/bn256/fq12.rs
index a7eeed1..4cd3b39 100644
--- a/pairings/src/bn256/fq12.rs
+++ b/pairings/src/bn256/fq12.rs
@@ -214,2 +214,3 @@ fn test_squaring() {
#[test]
+#[ignore]
fn fq12_field_tests() {
diff --git a/pairings/src/bn256/fq2.rs b/pairings/src/bn256/fq2.rs
index 95350d0..90f2acd 100644
--- a/pairings/src/bn256/fq2.rs
+++ b/pairings/src/bn256/fq2.rs
@@ -991,2 +991,3 @@ fn test_fq2_mul_nonresidue() {
#[test]
+#[ignore]
fn fq2_field_tests() {
diff --git a/pairings/src/bn256/fq6.rs b/pairings/src/bn256/fq6.rs
index aedc354..57d761c 100644
--- a/pairings/src/bn256/fq6.rs
+++ b/pairings/src/bn256/fq6.rs
@@ -393,2 +393,3 @@ fn test_fq6_mul_by_01() {
#[test]
+#[ignore]
fn fq6_field_tests() {
diff --git a/pairings/src/bn256/mod.rs b/pairings/src/bn256/mod.rs
index 0c41fd5..151b36b 100644
--- a/pairings/src/bn256/mod.rs
+++ b/pairings/src/bn256/mod.rs
@@ -472,2 +472,3 @@ use rand_xorshift::XorShiftRng;
#[test]
+#[ignore]
fn test_pairing() {
@@ -554,2 +555,3 @@ fn test_pairing() {
#[test]
+#[ignore]
fn random_bilinearity_tests() {
@@ -597,2 +599,3 @@ fn random_bilinearity_tests() {
#[test]
+#[ignore]
fn bn256_engine_tests() { |
clehner
reviewed
Sep 24, 2021
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
|
Tests passed on my machine (after about 20 minutes) |
Yes there is a long running test. Should we set it to ignore? |
I think so |
Signed-off-by: Michael Lodder <redmike7@gmail.com>
|
@mikelodder7 Thanks for adding that Unfortunately, there is a CI/test failure in https://github.com/spruceid/ssi/runs/3952962118?check_suite_focus=true#step:5:619 which I reproduce now: Changing from the Using |
|
That's odd because it has nothing to do with what I changed. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this is massive but its all the accumulator stuff.