Test RevocationList2020Status in VC API #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RevocationList2020StatustocredentialStatusesSupportedin the local VC (HTTP) API Test Suite config, to cause Revocation List 2020 functionality to be tested. This should have been added before, but was forgotten. However, adding it now will probably cause test failure, as the test revocation list credential and its dependent credential statuses have been broken in the renaming ofvc-http-apitovc-api: w3c-ccg/vc-api#236The test suite itself could also be similarly updated for Spruce's demo instance: https://github.com/w3c-ccg/vc-api-test-suite/blob/a74c63d2d015efcb1c5d22a5d283536026faf5ec/packages/vc-http-api-test-server/config/Spruce.js#L18
Edit: actually, this change would cause issuer tests to run as well, which DIDKit doesn't currently support: the
credentialStatusissuance option is supposed to result in acredentialStatusobject added to the resulting verifiable credential:https://github.com/w3c-ccg/vc-api-test-suite/blob/a74c63d2d015efcb1c5d22a5d283536026faf5ec/packages/vc-http-api-test-server/__tests__/issueCredential.spec.js#L126-L166