New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests for 3 figure versions in user agent string #1476

Open

mauritslamers wants to merge 1 commit into master from team/mauritslamers/three-figure-version-user-agent-strings

Member

mauritslamers commented Mar 30, 2022

With both Chrome and Firefox nearing version 100, we need to make sure that the detection of these numbers doesn't cause issues.


          add unit tests for 3 figure versions in user agent string

06389d6

mauritslamers requested a review from nicolasbadia

March 30, 2022 13:58

Member Author

mauritslamers commented Mar 30, 2022

@nicolasbadia If you know any other typical locations where this might be a problem please let me know, or feel free to add them to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment