Fix build issue with latest node version #74
Conversation
|
Wouldn't this cause a node v7 package to be installed under node v8? If yes, that could cause problems because of the ABI differences. |
|
Ah! I didn't know, sorry about that. So the only solution right now is to downgrade to node v7? |
|
Yes, at the moment this is the only solution. Problem is that we have to
deprecate some older versions of node in order to support newer versions
because of compilation issues with node-canvas.
Another solution would be to get rid of the image slicing currently
required by the ace theme as that is the only reason this is required of
node-canvas.
Op 6 aug. 2017 21:40 schreef "Belal Sejouk" <notifications@github.com>:
… Ah! I didn't know, sorry about that. So the only solution right now is to
downgrade to node v7?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA5GIbXH4hHR_FB3mbHgkMoChaivJYcks5sVhaRgaJpZM4Ouni1>
.
|
|
How could I get rid of image slicing? The issue I'm facing is that I am not even able to install sproutcore, because it stops at node-canvas. Does that mean I'd have to install it without npm? I'm not sure how to do that properly |
|
Okay so I was finally able to install it using node v7.10.1. I downgraded it using nvm. Also, it had permission issues so I ran it as |
|
Great! Sorry for all the trouble. This is slowly asking for a 1.12 version where the slicing is gone. At the same time we are working on a 2.0 release so this complicates things a bit. |
|
We are about to drop slicing from the BT, which also resolves the base problem here. Slicing will be available (if required) through a separate npm package sproutcore-slicing which will enable slicing if required. As soon as these packages are released, this PR will be closed. |
I have node version 8, but I couldn't install sproutcore because it was looking for v8.0 of this package.