Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump jacksonVersion from 2.16.2 to 2.17.0 #660

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 18, 2024

Bumps jacksonVersion from 2.16.2 to 2.17.0.
Updates com.fasterxml.jackson.core:jackson-core from 2.16.2 to 2.17.0

Commits
  • 8fba680 [maven-release-plugin] prepare release jackson-core-2.17.0
  • 486b33f Prepare for 2.17.0 release
  • a6a1074 Merge branch '2.16' into 2.17
  • e5b5e34 Back to snapshot deps
  • 8938de4 [maven-release-plugin] prepare for next development iteration
  • e2cc65d Bump the github-actions group with 3 updates (#1236)
  • d29507f Improve #1149 wrt JsonParser.getNumberTypeFP() default implementation (#1235)
  • 1994217 Add explicit override for JSON parsers for JsonParser.getNumberTypeFP()
  • f788391 Back to snapshot deps
  • bf672c0 [maven-release-plugin] prepare for next development iteration
  • Additional commits viewable in compare view

Updates com.fasterxml.jackson.core:jackson-annotations from 2.16.2 to 2.17.0

Commits

Updates com.fasterxml.jackson.core:jackson-databind from 2.16.2 to 2.17.0

Commits

Updates com.fasterxml.jackson.dataformat:jackson-dataformat-yaml from 2.16.2 to 2.17.0

Commits
  • 5947a45 [maven-release-plugin] prepare release jackson-dataformats-text-2.17.0
  • 66e39ff Prepare for 2.17.0 release
  • 00d45d2 Merge branch '2.16' into 2.17
  • 17b06ec Back to snapshot dep
  • 6924d24 [maven-release-plugin] prepare for next development iteration
  • 5f89d60 Add explicit overrides for JsonParser.getNumberTypeFP()
  • 1b8ca46 Test renaming
  • 0550039 Minor test refactoring
  • a743df1 YAML: consider starting # and ending : as quotable characters (#465)
  • c603bd9 Back to snapshot deps
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for springwolf-ui canceled.

Name Link
🔨 Latest commit 13e14b6
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/660fb14ffcf6c80008a00a74

@timonback
Copy link
Member

Clashes with https://mvnrepository.com/artifact/io.swagger.core.v3/swagger-core-jakarta at the moment.
Waiting for a resolution as part of the dependency before re-defining dependencies in springwolf

@ctasada
Copy link
Collaborator

ctasada commented Apr 1, 2024

Adding an explicit dependency with jackson-core solves the issue. Even when we shouldn't define transitive dependencies, we either define that dependency or use jackson-bom to guarantee alignment.

@timonback I pushed a commit adding jackson-core to unblock in the easier way.

@timonback
Copy link
Member

:thumbup: Fine with me.

Do you know more about bom with gradle?
The gradle example seems complex for what it does: https://docs.gradle.org/current/userguide/dependency_version_alignment.html#sec:align_bom_platform

@timonback
Copy link
Member

:thumbup: Fine with me.

Do you know more about bom with gradle?
The gradle example seems complex for what it does: https://docs.gradle.org/current/userguide/dependency_version_alignment.html#sec:align_bom_platform

@ctasada Are you able to rebase the branch in the future instead? That simplifies the git commit tree.

@ctasada ctasada force-pushed the dependabot/gradle/jacksonVersion-2.17.0 branch from 0ba7130 to 6ed8d76 Compare April 3, 2024 15:11
Bumps `jacksonVersion` from 2.16.2 to 2.17.0.

Updates `com.fasterxml.jackson.core:jackson-core` from 2.16.2 to 2.17.0
- [Commits](FasterXML/jackson-core@jackson-core-2.16.2...jackson-core-2.17.0)

Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.16.2 to 2.17.0
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.16.2 to 2.17.0
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.dataformat:jackson-dataformat-yaml` from 2.16.2 to 2.17.0
- [Commits](FasterXML/jackson-dataformats-text@jackson-dataformats-text-2.16.2...jackson-dataformats-text-2.17.0)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.core:jackson-annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.dataformat:jackson-dataformat-yaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

fix: Added missing dependency

jackson-databind uses jackson-core. Without the dependency defined, it was using, for some reason (probably due to swagger transitive dependencies), a different version, making the execution to fail due to mismatched SDK versions.

fix: Properly replaced by the BOM

fix: Properly replaced by the BOM

fix: Added missing dependency

jackson-databind uses jackson-core. Without the dependency defined, it was using, for some reason (probably due to swagger transitive dependencies), a different version, making the execution to fail due to mismatched SDK versions.
@ctasada ctasada force-pushed the dependabot/gradle/jacksonVersion-2.17.0 branch from cbf2343 to 8ec2705 Compare April 3, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants