Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify practices regarding browser polyfills and third party CDNs #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josebolos
Copy link
Contributor

@josebolos josebolos commented Mar 6, 2024

  • Adds link explaining what a browser polyfill is.
  • Adds the data protection risk to the "use of third party CDN" risks.
  • Makes it clearer that using third party CDNs is not an acceptable practice, ever, both in the "static resources" page and in the "polyfill" section of the javascript house style page.
  • Also minor whitespace adjustments and updating TOCs for consistency.

Makes it clear that using third party CDNs is not an acceptable practice, ever.

Also minor whitespace adjustments and updating TOCs for consistency.
@josebolos josebolos changed the title Clarify practices regarding third party CDNs Clarify practices regarding browser polyfills and third party CDNs Mar 6, 2024
@benjclark
Copy link
Contributor

I wonder if we should suggest that any NPM dependency used to load polyfills should be locked down to an exact version in a package.json / package-lock.json, and that version range syntax should not be used. To mitigate risk of an NPM dependency getting compromised and publishing code that we import and load in production. But I guess that applies to any NPM dependency used in production code.

@josebolos
Copy link
Contributor Author

josebolos commented Mar 7, 2024

@benjclark Yeah, good point. Interestingly, we also suggest using SRI which, if my understanding is correct, could also help with these issues. I don't think we use it extensively, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants