Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds info re self-hosting fonts #403

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Adds info re self-hosting fonts #403

wants to merge 3 commits into from

Conversation

jon-stevens
Copy link
Contributor

@jon-stevens jon-stevens commented Feb 1, 2022 •
edited

blep-font

axemonkey
axemonkey previously approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@axemonkey axemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotcode
Copy link
Contributor

dotcode commented Feb 1, 2022

Do not merge, yet

@dotcode dotcode changed the title Adds info re self-hosting fonts DO NOT MERGE - Adds info re self-hosting fonts Feb 3, 2022
@dotcode dotcode marked this pull request as draft February 4, 2022 11:17
@dotcode dotcode changed the title DO NOT MERGE - Adds info re self-hosting fonts Adds info re self-hosting fonts Feb 4, 2022
@jon-stevens @josebolos
Update performance/font-loading.md
30968d6 
Co-authored-by: Jose Bolos <joseluisbolos@gmail.com>
@jon-stevens jon-stevens requested a review from dotcode May 16, 2023 14:39
@jpw
Copy link
Contributor

jpw commented Oct 4, 2023

@dotcode @josebolos are there issues preventing this being merged?

@josebolos
Copy link
Contributor

I'm happy with it, but I think that @dotcode had some concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpw jpw jpw left review comments

@SamLeach SamLeach SamLeach left review comments

@josebolos josebolos josebolos left review comments

@axemonkey axemonkey axemonkey left review comments

@dotcode dotcode Awaiting requested review from dotcode

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
good practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jon-stevens @dotcode @jpw @josebolos @axemonkey @SamLeach