Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supportedMediaTypes to the ProducesRequestCondition #301

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from

Conversation

ptahchiev
Copy link

If we don't add the supportedMediaTypes from the registered HttpMessageConverters,
then even through the customer might register another httpMessageConverter they won't be able
to get the response in the desired format.

See DATAREST-1235

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

If we don't add the supportedMediaTypes from the registered HttpMessageConverters,
then even through the customer might register another httpMessageConverter they won't be able
to get the response in the desired format.

See DATAREST-1235
@odrotbohm
Copy link
Member

Any chance you add some test cases?

@ptahchiev
Copy link
Author

Hi @olivergierke I could, however this PR is not complete atm. When I run the tests I see one test is failing as I have described in the ticket comment: https://jira.spring.io/browse/DATAREST-1235
I am really not sure what is the correct way to proceed here - I really need your advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants