Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NPE from occurring #2362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

birariro
Copy link

@birariro birariro commented Feb 8, 2024

Hi,
I think NotNull Message looks better than NPE.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 8, 2024
@mp911de
Copy link
Member

mp911de commented Feb 8, 2024

How did you encounter a null pointer at ValidationErrors? Do you have a stack trace handy?

@birariro
Copy link
Author

birariro commented Feb 9, 2024

There is no reason for an NPE to occur in ValidationErrors.
But if you look at the existing code
Assert.notNull(source, "Entity must not be null");

Since there is a logic to check null, I thought we considered the possibility of it occurring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants