Spring WebFlux with Netty Doesn't Gzip Static Resources Correctly

[brandongodwin]

Spring Boot Version

Tested with 2.0.1.RELEASE and the latest commit on master c43eb89.

Issue

When using Spring WebFlux with Netty and Gzip compression is enabled, the HTTP response correctly contains the content-encoding: gzip header, but the actual response body isn't compressed. This will cause Chrome to fail with ERR_CONTENT_DECODING_FAILED. Switching to a different sever, such as Undertow or Tomcat, will yield the correct result. Response bodies returned from a router function that are large enough to trigger compression seem to work fine, it only appears to happen for static resources.

Reproduction Steps

Using the spring-boot-sample-webflux project, create a public directory in src/main/resources/ and place this text file in there. Run the project with mvn spring-boot:run -Dserver.compression.enabled=true and navigate to http://localhost:8080/test.txt.

[wilkinsona]

This can be reproduced without using Spring Boot:

package com.example.demo;

import java.io.File;
import java.io.IOException;

import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import org.springframework.http.server.reactive.ReactorHttpHandlerAdapter;
import org.springframework.util.FileCopyUtils;
import org.springframework.web.reactive.config.EnableWebFlux;
import org.springframework.web.reactive.config.ResourceHandlerRegistry;
import org.springframework.web.reactive.config.WebFluxConfigurer;
import org.springframework.web.server.adapter.WebHttpHandlerBuilder;

import reactor.ipc.netty.http.server.HttpServer;

@EnableWebFlux
public class Gh12892Application implements WebFluxConfigurer {

	@Override
	public void addResourceHandlers(ResourceHandlerRegistry registry) {
		registry.addResourceHandler("/**").addResourceLocations(new File(".").getAbsoluteFile().toURI().toString());
	}

	public static void main(String[] args) throws IOException {
		FileCopyUtils.copy(new byte[1024], new File("test.txt"));
		AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(Gh12892Application.class);
		HttpServer server = HttpServer.builder().options((options) -> options.compression(true).port(8080)).build();
		server.startAndAwait(new ReactorHttpHandlerAdapter(WebHttpHandlerBuilder.applicationContext(context).build()));
	}

}

$ http :8080/test.txt
HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-Type: text/plain
Last-Modified: Fri, 27 Apr 2018 14:31:52 GMT
content-encoding: gzip
transfer-encoding: chunked


http: error: ContentDecodingError: ('Received response with content-encoding: gzip, but failed to decode it.', error('Error -3 while decompressing: incorrect header check',))

Here's the log output from Reactor Netty:

15:36:27.199 [reactor-http-nio-1] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x2ce217e6, L:/0:0:0:0:0:0:0:0:8080] READ: [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402]
15:36:27.199 [reactor-http-nio-1] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x2ce217e6, L:/0:0:0:0:0:0:0:0:8080] READ COMPLETE
15:36:27.199 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - New http connection, requesting read
15:36:27.200 [reactor-http-nio-2] DEBUG reactor.ipc.netty.channel.ContextHandler - After pipeline DefaultChannelPipeline{(reactor.left.loggingHandler = io.netty.handler.logging.LoggingHandler), (ServerContextHandler#0 = reactor.ipc.netty.channel.ServerContextHandler), (reactor.left.httpCodec = io.netty.handler.codec.http.HttpServerCodec), (reactor.left.httpServerHandler = reactor.ipc.netty.http.server.HttpServerHandler), (reactor.right.reactiveBridge = reactor.ipc.netty.channel.ChannelOperationsHandler)}
15:36:27.200 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] REGISTERED
15:36:27.200 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] ACTIVE
15:36:27.200 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] READ: 143B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 47 45 54 20 2f 74 65 73 74 2e 74 78 74 20 48 54 |GET /test.txt HT|
|00000010| 54 50 2f 31 2e 31 0d 0a 48 6f 73 74 3a 20 6c 6f |TP/1.1..Host: lo|
|00000020| 63 61 6c 68 6f 73 74 3a 38 30 38 30 0d 0a 43 6f |calhost:8080..Co|
|00000030| 6e 6e 65 63 74 69 6f 6e 3a 20 6b 65 65 70 2d 61 |nnection: keep-a|
|00000040| 6c 69 76 65 0d 0a 41 63 63 65 70 74 2d 45 6e 63 |live..Accept-Enc|
|00000050| 6f 64 69 6e 67 3a 20 67 7a 69 70 2c 20 64 65 66 |oding: gzip, def|
|00000060| 6c 61 74 65 0d 0a 41 63 63 65 70 74 3a 20 2a 2f |late..Accept: */|
|00000070| 2a 0d 0a 55 73 65 72 2d 41 67 65 6e 74 3a 20 48 |*..User-Agent: H|
|00000080| 54 54 50 69 65 2f 30 2e 39 2e 33 0d 0a 0d 0a    |TTPie/0.9.3.... |
+--------+-------------------------------------------------+----------------+
15:36:27.200 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - Increasing pending responses, now 1
15:36:27.200 [reactor-http-nio-2] DEBUG io.netty.channel.DefaultChannelPipeline - Discarded inbound message DefaultHttpRequest(decodeResult: success, version: HTTP/1.1)
GET /test.txt HTTP/1.1
Host: localhost:8080
Connection: keep-alive
Accept-Encoding: gzip, deflate
Accept: */*
User-Agent: HTTPie/0.9.3 that reached at the tail of the pipeline. Please check your pipeline configuration.
15:36:27.200 [reactor-http-nio-2] DEBUG reactor.ipc.netty.ReactorNetty - Added encoder [reactor.left.compressionHandler] at the beginning of the user pipeline, full pipeline: [reactor.left.loggingHandler, reactor.left.httpCodec, reactor.left.httpServerHandler, reactor.left.compressionHandler, reactor.right.reactiveBridge, DefaultChannelPipeline$TailContext#0]
15:36:27.200 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] READ COMPLETE
15:36:27.201 [reactor-http-nio-2] DEBUG reactor.ipc.netty.channel.ChannelOperations - [HttpServer] [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] handler is being applied: org.springframework.http.server.reactive.ReactorHttpHandlerAdapter@5296e5c8
15:36:27.201 [reactor-http-nio-2] DEBUG org.springframework.web.reactive.DispatcherHandler - Processing GET request for [http://localhost:8080/test.txt]
15:36:27.201 [reactor-http-nio-2] DEBUG org.springframework.web.reactive.result.method.annotation.RequestMappingHandlerMapping - Looking up handler method for path /test.txt
15:36:27.201 [reactor-http-nio-2] DEBUG org.springframework.web.reactive.result.method.annotation.RequestMappingHandlerMapping - Did not find handler method for [/test.txt]
15:36:27.201 [reactor-http-nio-2] DEBUG org.springframework.web.reactive.handler.SimpleUrlHandlerMapping - Matching pattern for request [[path='/test.txt']] is /**
15:36:27.201 [reactor-http-nio-2] DEBUG org.springframework.web.reactive.handler.SimpleUrlHandlerMapping - Mapping [[path='/test.txt']] to ResourceWebHandler [locations=[URL [file:/Users/awilkinson/dev/workspaces/spring/spring-boot/master/gh-12892/./]], resolvers=[org.springframework.web.reactive.resource.PathResourceResolver@2dd03a7f]]
15:36:27.202 [reactor-http-nio-2] DEBUG reactor.ipc.netty.channel.ChannelOperationsHandler - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] Writing object DefaultHttpResponse(decodeResult: success, version: HTTP/1.1)
HTTP/1.1 200 OK
Last-Modified: Fri, 27 Apr 2018 14:31:52 GMT
Content-Length: 1024
Content-Type: text/plain
Accept-Ranges: bytes
15:36:27.202 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: 165B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 48 54 54 50 2f 31 2e 31 20 32 30 30 20 4f 4b 0d |HTTP/1.1 200 OK.|
|00000010| 0a 4c 61 73 74 2d 4d 6f 64 69 66 69 65 64 3a 20 |.Last-Modified: |
|00000020| 46 72 69 2c 20 32 37 20 41 70 72 20 32 30 31 38 |Fri, 27 Apr 2018|
|00000030| 20 31 34 3a 33 31 3a 35 32 20 47 4d 54 0d 0a 43 | 14:31:52 GMT..C|
|00000040| 6f 6e 74 65 6e 74 2d 54 79 70 65 3a 20 74 65 78 |ontent-Type: tex|
|00000050| 74 2f 70 6c 61 69 6e 0d 0a 41 63 63 65 70 74 2d |t/plain..Accept-|
|00000060| 52 61 6e 67 65 73 3a 20 62 79 74 65 73 0d 0a 63 |Ranges: bytes..c|
|00000070| 6f 6e 74 65 6e 74 2d 65 6e 63 6f 64 69 6e 67 3a |ontent-encoding:|
|00000080| 20 67 7a 69 70 0d 0a 74 72 61 6e 73 66 65 72 2d | gzip..transfer-|
|00000090| 65 6e 63 6f 64 69 6e 67 3a 20 63 68 75 6e 6b 65 |encoding: chunke|
|000000a0| 64 0d 0a 0d 0a                                  |d....           |
+--------+-------------------------------------------------+----------------+
15:36:27.202 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] FLUSH
15:36:27.202 [reactor-http-nio-2] DEBUG reactor.ipc.netty.channel.ChannelOperationsHandler - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] Writing object io.netty.channel.DefaultFileRegion@68871905
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: 5B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 34 30 30 0d 0a                                  |400..           |
+--------+-------------------------------------------------+----------------+
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: io.netty.channel.DefaultFileRegion@68871905
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: 2B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 0d 0a                                           |..              |
+--------+-------------------------------------------------+----------------+
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] FLUSH
15:36:27.203 [reactor-http-nio-2] DEBUG org.springframework.http.server.reactive.ReactorHttpHandlerAdapter - Handling completed with success
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - Last HTTP response frame
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.channel.ChannelOperationsHandler - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] Writing object EmptyLastHttpContent
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: 4B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 31 34 0d 0a                                     |14..            |
+--------+-------------------------------------------------+----------------+
15:36:27.203 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: 20B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 1f 8b 08 00 00 00 00 00 00 00 03 00 00 00 00 00 |................|
|00000010| 00 00 00 00                                     |....            |
+--------+-------------------------------------------------+----------------+
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: 2B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 0d 0a                                           |..              |
+--------+-------------------------------------------------+----------------+
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] WRITE: 5B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 30 0d 0a 0d 0a                                  |0....           |
+--------+-------------------------------------------------+----------------+
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - Decreasing pending responses, now 0
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] FLUSH
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.ReactorNetty - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] Removed handler: reactor.left.compressionHandler, pipeline: DefaultChannelPipeline{(reactor.left.loggingHandler = io.netty.handler.logging.LoggingHandler), (reactor.left.httpCodec = io.netty.handler.codec.http.HttpServerCodec), (reactor.left.httpServerHandler = reactor.ipc.netty.http.server.HttpServerHandler), (reactor.right.reactiveBridge = reactor.ipc.netty.channel.ChannelOperationsHandler)}
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] USER_EVENT: [Handler Terminated]
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.channel.ChannelOperationsHandler - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] Disposing context reactor.ipc.netty.channel.ServerContextHandler@662ac06b
15:36:27.204 [reactor-http-nio-2] DEBUG reactor.ipc.netty.channel.ChannelOperations - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] Discarding inbound content
15:36:27.205 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50402] READ COMPLETE
15:36:27.205 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 ! R:/0:0:0:0:0:0:0:1:50402] INACTIVE
15:36:27.205 [reactor-http-nio-2] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x670506c8, L:/0:0:0:0:0:0:0:1:8080 ! R:/0:0:0:0:0:0:0:1:50402] UNREGISTERED

Interestingly, when using curl as the client the response changes to a 400:

$ curl -i :8080/test.txt
HTTP/1.1 400 Bad Request
content-length: 0

Here's the corresponding log output:

15:37:51.602 [reactor-http-nio-1] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x2ce217e6, L:/0:0:0:0:0:0:0:0:8080] READ: [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406]
15:37:51.602 [reactor-http-nio-1] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x2ce217e6, L:/0:0:0:0:0:0:0:0:8080] READ COMPLETE
15:37:51.603 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - New http connection, requesting read
15:37:51.603 [reactor-http-nio-3] DEBUG reactor.ipc.netty.channel.ContextHandler - After pipeline DefaultChannelPipeline{(reactor.left.loggingHandler = io.netty.handler.logging.LoggingHandler), (ServerContextHandler#0 = reactor.ipc.netty.channel.ServerContextHandler), (reactor.left.httpCodec = io.netty.handler.codec.http.HttpServerCodec), (reactor.left.httpServerHandler = reactor.ipc.netty.http.server.HttpServerHandler), (reactor.right.reactiveBridge = reactor.ipc.netty.channel.ChannelOperationsHandler)}
15:37:51.603 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] REGISTERED
15:37:51.603 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] ACTIVE
15:37:51.603 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] READ: 77B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 47 45 54 20 2f 74 65 73 74 2e 74 78 74 20 48 54 |GET /test.txt HT|
|00000010| 54 50 2f 31 2e 31 0d 0a 48 6f 73 74 3a 20 3a 38 |TP/1.1..Host: :8|
|00000020| 30 38 30 0d 0a 55 73 65 72 2d 41 67 65 6e 74 3a |080..User-Agent:|
|00000030| 20 63 75 72 6c 2f 37 2e 34 36 2e 30 0d 0a 41 63 | curl/7.46.0..Ac|
|00000040| 63 65 70 74 3a 20 2a 2f 2a 0d 0a 0d 0a          |cept: */*....   |
+--------+-------------------------------------------------+----------------+
15:37:51.603 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - Increasing pending responses, now 1
15:37:51.603 [reactor-http-nio-3] DEBUG io.netty.channel.DefaultChannelPipeline - Discarded inbound message DefaultHttpRequest(decodeResult: success, version: HTTP/1.1)
GET /test.txt HTTP/1.1
Host: :8080
User-Agent: curl/7.46.0
Accept: */* that reached at the tail of the pipeline. Please check your pipeline configuration.
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.ReactorNetty - Added encoder [reactor.left.compressionHandler] at the beginning of the user pipeline, full pipeline: [reactor.left.loggingHandler, reactor.left.httpCodec, reactor.left.httpServerHandler, reactor.left.compressionHandler, reactor.right.reactiveBridge, DefaultChannelPipeline$TailContext#0]
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] READ COMPLETE
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.channel.ChannelOperations - [HttpServer] [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] handler is being applied: org.springframework.http.server.reactive.ReactorHttpHandlerAdapter@5296e5c8
15:37:51.604 [reactor-http-nio-3] WARN org.springframework.http.server.reactive.ReactorHttpHandlerAdapter - Invalid URL for incoming request: Expected hostname at index 7: http://:8080
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - Last HTTP response frame
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - No sendHeaders() called before complete, sending zero-length header
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.channel.ChannelOperationsHandler - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] Writing object DefaultFullHttpResponse(decodeResult: success, version: HTTP/1.1, content: EmptyByteBufBE)
HTTP/1.1 400 Bad Request
content-length: 0
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] WRITE: 47B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 48 54 54 50 2f 31 2e 31 20 34 30 30 20 42 61 64 |HTTP/1.1 400 Bad|
|00000010| 20 52 65 71 75 65 73 74 0d 0a 63 6f 6e 74 65 6e | Request..conten|
|00000020| 74 2d 6c 65 6e 67 74 68 3a 20 30 0d 0a 0d 0a    |t-length: 0.... |
+--------+-------------------------------------------------+----------------+
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServerOperations - Decreasing pending responses, now 0
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] FLUSH
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.ReactorNetty - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] Removed handler: reactor.left.compressionHandler, pipeline: DefaultChannelPipeline{(reactor.left.loggingHandler = io.netty.handler.logging.LoggingHandler), (reactor.left.httpCodec = io.netty.handler.codec.http.HttpServerCodec), (reactor.left.httpServerHandler = reactor.ipc.netty.http.server.HttpServerHandler), (reactor.right.reactiveBridge = reactor.ipc.netty.channel.ChannelOperationsHandler)}
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] USER_EVENT: [Handler Terminated]
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.channel.ChannelOperationsHandler - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] Disposing context reactor.ipc.netty.channel.ServerContextHandler@662ac06b
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.channel.ChannelOperations - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] Discarding inbound content
15:37:51.604 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 - R:/0:0:0:0:0:0:0:1:50406] READ COMPLETE
15:37:51.605 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 ! R:/0:0:0:0:0:0:0:1:50406] INACTIVE
15:37:51.605 [reactor-http-nio-3] DEBUG reactor.ipc.netty.http.server.HttpServer - [id: 0x6ab65991, L:/0:0:0:0:0:0:0:1:8080 ! R:/0:0:0:0:0:0:0:1:50406] UNREGISTERED

[wilkinsona]

The problem with curl is a red herring. curl :8080 sends the Host header as :8080. curl localhost:8080 sends a legal Host header which fixes the 400 response.

[wilkinsona]

With thanks to @violetagg, we believe this is a Reactor Netty bug caused by zero copy being used even when compression is enabled. I've opened reactor/reactor-netty#340. We'll pick up a version of Reactor Netty containing the fix in due course.

[montgomery1944]

@wilkinsona, it seems that this issue still occurs for 2.0.4.RELEASE version following the same steps as @Brandon-Godwin presented. Could you please check it?

[wilkinsona]

@montgomery1944 It works for me with Spring Boot 2.0.4.RELEASE with the example from @Brandon-Godwin. If you would like us to investigate further, please open a new issue with a minimal, complete, and verifiable example of the problem.

[RobMaskell]

@wilkinsona I have seen the this same issue not be fixed in 2.0.4 RELEASE could I very respectfully (as I'm bound to be wrong here) ask how you tested it? It works for me with curl but only because it doesn't send a Accept-Encoding: gzip, deflate header by default whereas it fails using httpie which does.
To test it I created a brand new project from spring.io, added webflux only, added a static index.html file big enough to be over the default limit and the following minimal config in application.properties

server.port=8888
server.compression.enabled=true

I couldn't see that @montgomery1944 had created a new ticket with a sample app but I'm happy to do that

[wilkinsona]

I can't recall how I tested it, but I must have done something wrong as, having tested it again with 2.0.4, I can reproduce the problem. Thanks for the nudge to double-check.

As before, the problem can be reproduced without Boot with a small modification to the reproduction I posted above. If a predicate is used to control compression (even one that always returns true) then it'll fail:

package com.example.demo;

import java.io.File;
import java.io.IOException;

import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import org.springframework.http.server.reactive.ReactorHttpHandlerAdapter;
import org.springframework.util.FileCopyUtils;
import org.springframework.web.reactive.config.EnableWebFlux;
import org.springframework.web.reactive.config.ResourceHandlerRegistry;
import org.springframework.web.reactive.config.WebFluxConfigurer;
import org.springframework.web.server.adapter.WebHttpHandlerBuilder;

import reactor.ipc.netty.http.server.HttpServer;

@EnableWebFlux
public class Gh12892Application implements WebFluxConfigurer {

	@Override
	public void addResourceHandlers(ResourceHandlerRegistry registry) {
		registry.addResourceHandler("/**").addResourceLocations(new File(".").getAbsoluteFile().toURI().toString());
	}

	public static void main(String[] args) throws IOException {
		FileCopyUtils.copy(new byte[1024], new File("test.txt"));
		AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(Gh12892Application.class);
		HttpServer server = HttpServer.builder().options((options) -> options.compression((req, resp) -> true).port(8080)).build();
		server.startAndAwait(new ReactorHttpHandlerAdapter(WebHttpHandlerBuilder.applicationContext(context).build()));
	}

}