Prevent Content-Length and Host headers from being copied by default #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkuipers
force-pushed
the
exclude-content-length
branch
from
c563880
to
482690b
Compare
Also remove the bogus spring.cloud.gateway.proxy.auto-forward setting from the tests. Fixes spring-cloudgh-3154
jkuipers
force-pushed
the
exclude-content-length
branch
from
482690b
to
310d7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an additional property to skip copying certain headers from the incoming request.
Because the use case is different, it's bad to force users to add headers like
HostandContent-Lengthto the list of sensitive headers when they need to override that (e.g. for adding smth like anX-APIKeyheader), so having a separate configuration setting for this is preferable.Fixes gh-3154