Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework LocalResponseCache into a general ResponseCache to support Caffiene and Redis CacheManagers #3145

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JesseEstum
Copy link
Contributor

LocalResponseCacheGatewayFilterFactory offers a lot of great functionality assuming that you're fine with a Caffiene-backed cache implementation. For my particular use case, I'm interested in using a Redis cache and distributing the cache storage across several instances of the spring-cloud-gateway app.

This pull request:

  1. renames parts of the plumbing that are common regardless of caching implementation from LocalResponseCache* to ResponseCache*
  2. adds auto configuration for Redis-backed CacheManager
  3. changes the access modifiers of some classes/methods in order to make my use case work out

Any feedback/suggestions are appreciated. If modifications are required in order to get this back into the mainline please let me know.

@spencergibb
Copy link
Member

Anything we do at this point needs to be backwards compatible. We don't do breaking changes, for the most part, unless it's a major release and we will not be doing one for a while.

@JesseEstum
Copy link
Contributor Author

@spencergibb that makes sense. I'm willing to work on shuffling this around into a non-breaking PR.

Breaking changes aside - Do you have any feedback on the idea behind the PR? Is there appetite for inclusion of a pluggable cache implementation for response caching?

@spencergibb
Copy link
Member

I think it makes sense, but it would need to be reworked. No rush.

@spencergibb
Copy link
Member

Any chance you can rebase? No rush, this would be part of our 2024.0 release train.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

3 participants