Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shipping & tax calculations in javascript when free shipping prom… #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrbrdo
Copy link
Contributor

@mrbrdo mrbrdo commented Nov 6, 2022

…otion is applied

@nciemniak
Copy link
Contributor

@mrbrdo can you give me details on how to reproduce the bug?

@mrbrdo
Copy link
Contributor Author

mrbrdo commented Dec 2, 2022

@nciemniak
Create a promotion (coupon code...) for example on order above $100, applies free shipping. Use a default shipping method that has a price, and another shipping method which is free (like in-store pickup for example). Then try to check out with an order above $100 and watch carefully the cost of shipping listed in the checkout steps, and try to switch between both possible shipping options. I think that should do it. In my setup I use an EU VAT rate which is included in the price (might be relevant or not, don't remember).
Too bad I did not put more details in the commit message, I have to do that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants