Correctly calculate last_modified_index when the @products scope is u… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing GROUP BY In this case, maximum(:updated_at) is not a single value but rather a hash.
| @@ -107,7 +107,15 @@ def etag_show | |||
| alias product_etag etag_show | |||
|
|
|||
| def last_modified_index | |||
| products_last_modified = @products.maximum(:updated_at)&.utc if @products.respond_to?(:maximum) | |||
| if @products.respond_to?(:maximum) | |||
There was a problem hiding this comment.
@mrbrdo just wondering - are there any cases where @products won't respond to .maximum?
There was a problem hiding this comment.
I don't think so (except if @products is nil but I don't think that's an allowed state). I didn't add that if, just kept it from before (was at end of line). And git blame shows it being copied around from another place, I didn't dig deeper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sing GROUP BY
In this case, maximum(:updated_at) is not a single value but rather a hash.
Basically I just added handling the possible Hash result of #maximum.