2 2 stable #179
Open
2 2 stable #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change makes it easier for people to create their own calculators and stops errors from happening when they previously forget to call is_package_shippable? inside compute_package, there currently is a lot of logic inside compute_package and the cleaner we keep it the better. fixes spree-contrib#164 fixes spree-contrib#171
else zero? will fail
|
@gus4no This PR seems to have a lot of unrelated commits attached to it. Could you please split this PR into two? |
Searching by slug instead by permalink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting a NoMethodError due to nil.(:>, 0).
Using
is_package_shippable?insideavailable?fixes missingis_package_shippable?call insidecompute_packageofSpree::Calculator::Shipping::Usps::PriorityMailInternationalIf this was left out for a specific reason, would you be kind explaining me why?