New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature spec #200

Open

essa wants to merge 1 commit into spree-contrib:1-3-stable from degica:fix_feature_spec

essa commented Nov 28, 2017

This fixes the broken feature spec, spec/features/paypal_spec.rb.

I found this spec fails and was skipped on other stable branches. I need to customize this gem for our site so I fixed the specs.

Following changes were needed to run it against current PayPal site.

Versionfile was needed to generate a test app by rake test_app
Need to specify version of rake
I Changed many queries for HTML elements to match the current PayPal site
I inserted many sleeps for waiting PayPal client side scripts to be ready

Here's difficult or mysterious parts for adjusting test script for PayPal site.

The new login form is inside of an iframe although there are hidden input fields of email and password outside of it
Most of event handlers take some seconds after visual elements appear on browser, so I need to insert sleep for waiting it
With geckodriver, cookies are reused so login page of PayPal will be skipped when we run many tests at once.

I think this is used for master or other stable branches but I made a PR for 1-3-stable which I'm using now.


          Fix feature spec

109cdd2

essa closed this

essa reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment