Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoints, Migrate PR #168 from 2-4-stable to 3-0-stable #177

Open
wants to merge 5 commits into
base: 3-0-stable
Choose a base branch
from

Conversation

givanse
Copy link

@givanse givanse commented Aug 3, 2015

Migrate PR #168 from 2-4-stable to 3-0-stable.

I had 1 local failure, but I don't think is related to any of the PR changes. See: #176 Maybe Travis results will come up fine.

williscool and others added 4 commits August 2, 2015 22:31
basically just takes what the regular spree version does and lets you do
it passing json

also made simple poro model for returning the url to redirect to on
paypal

Conflicts:
	spree_paypal_express.gemspec
@givanse
Copy link
Author

givanse commented Aug 3, 2015

Travis fails with the same error reported in #176, at least is consistent.

The failure is not related at all with the changes of this PR.

@williscool
Copy link

@MisinformedDNA

@alexw23
Copy link

alexw23 commented Aug 31, 2015

What's the latest on this @givanse ?

@alexw23
Copy link

alexw23 commented Aug 31, 2015

We should look at taking this logic for the API instead and putting it along with spree/spree_gateway#232

@givanse
Copy link
Author

givanse commented Sep 1, 2015

The PR is complete, but its blocked by #176

@lynndylanhurley
Copy link

@givanse - I'm trying to use this code in my project. Can you point me to documentation on how the API requests / responses should look for this PR?

Something like this walkthrough would be great:
https://github.com/spree-contrib/spree_api_examples/blob/master/examples/checkout/walkthrough.rb

@givanse
Copy link
Author

givanse commented Apr 4, 2016

I never got this branch to work (see #176). I went with 2-4-stable.

When I was working with this gem I was building an Ember app, the addon I used for it is here: https://github.com/aethermx/spree-ember-paypal-express That repo should give you an idea of how the frontend is talking to the backend. It feels like this was ages ago. If that addon is of no help, feel free to ping me again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants